GlobalFishingWatch / gfwr

R package for accessing data from Global Fishing Watch APIs
https://globalfishingwatch.github.io/gfwr/
Apache License 2.0
58 stars 7 forks source link

replace references to `user_json` for clarity #161

Closed AndreaSanchezTapia closed 1 month ago

AndreaSanchezTapia commented 1 month ago

Hi. Hope you don't mind me jumping in, but I had a thought about argument naming! I notice in the latest version of gfwr, get_raster() has had some changes, one of which is that the user specified region should be an sf object (great enhancement, thanks!). Given this change, wouldn't it make sense to use region_source = "user_polygon", or something similar, rather than "user_json"?

Originally posted by @jflowernet in https://github.com/GlobalFishingWatch/gfwr/issues/146#issuecomment-2221957585