GlobalFishingWatch / gfwr

R package for accessing data from Global Fishing Watch APIs
https://globalfishingwatch.github.io/gfwr/
Apache License 2.0
58 stars 7 forks source link

WCPFC RFMO region does not cross dateline #95

Closed jflowernet closed 1 year ago

jflowernet commented 1 year ago

Hi GFW crew,

I just ran a query for the WCPFC tuna RFMO region:

gfw_data_2020 <- get_raster(spatial_resolution = 'low', temporal_resolution = 'yearly', group_by = 'gearType', date_range = '2020-01-01,2020-12-31', region = 'WCPFC', region_source = 'trfmo')

Returns data fine, but only on the right hand side of the dateline, longitude min = -180 and max = -130. Seems like the polygon used to define the WCPFC region is truncated at the dateline?

As ever, thanks for the excellent gfwr package!

jflowernet commented 1 year ago

For reference, here's the WCPFC region: https://www.wcpfc.int/doc/convention-area-map

natemiller commented 1 year ago

Thanks for reporting the issue @jflowernet. There was an error in how the API was dealing with the antimeridian for that shape. It has been updated by the engineers now, but the the new shape is so large that it takes significant time to pull more than 3 months of data. There is a fix in the works, which should be deployed December 15. So for now if you are pulling less than 3 months of data, the code should now work. If you need to pull more than 3 months of data I would recommending waiting until after December 15 and then trying, otherwise the request will likely be exceedingly slow.

Thanks for the report, glad you are using the package and I hope that as these fixes are rolled out they help you work with the data more easily.

jflowernet commented 1 year ago

Thanks for the quick fix @natemiller! I appreciate how responsive you and the rest of the GFW team have been to issues raised. gfwr is a fantastic package!

I'll close this for now, but feel free to reopen if you want to leave it till after the 15th