Closed enriquetuya closed 8 years ago
Popup content is related to https://github.com/GlobalFishingWatch/pelagos-api/issues/70 and the move of rendering of hardcoded popup stuff to pelagos-api. This very specific ordering and naming of fields should never have been a client issue to begin with.
Changing the layer name is possible in edit mode. Just click the title and change it.
Question: When no vessel info is available, could we use the series_group value, rather than the index, since that won't get messy if you add and remove multiple layers many times (the same vessel always have the same number)?
As for the color picker, should it set the high and low values to the same value?
@redhog I've updated the description.
@redhog
Conflicting files
js/app/Data/Selection.js
text-overflow: ellipsis;
to the layer name so this does not happen: I have fixed the conflict. The ellipsis doesn't work due to the dom strcuture and styling of other elements - the animation-title never gets its size restricted, and it's not possible to (easily) do that. If we reworked the styles and used display: table-cell, maybe... I suggest making the sidebar just ever so much wider by default...
@redhog The PR is still in conflict, I think it is due to the latest Categorized Blade merge.
Merged
In order to release the changes on https://github.com/GlobalFishingWatch/pelagos-client/issues/348 we would like to have some changes:
Vessel Track
the layer is named like the vessel that was saved and if that data is not present use the series_group value.Vessel name
instead ofvesselname
,MMSI
instead ofmmsi
,IMO
instead ofimo
,Callsign
instead ofcallsign
.Vessel Name
,MMSI
,Callsign
,IMO
,FLAG
. We don't want to display series and series group there.pin
the users are more used of having thepin
in all platforms as a way of retaining some information no matter what.Nice to have: