GlobalFishingWatch / pelagos-client

Documentation
http://globalfishingwatch.io/pelagos-client/
Other
7 stars 4 forks source link

Changes for multiple vessel functionality #391

Closed enriquetuya closed 8 years ago

enriquetuya commented 8 years ago

In order to release the changes on https://github.com/GlobalFishingWatch/pelagos-client/issues/348 we would like to have some changes:

Nice to have:

redhog commented 8 years ago

Popup content is related to https://github.com/GlobalFishingWatch/pelagos-api/issues/70 and the move of rendering of hardcoded popup stuff to pelagos-api. This very specific ordering and naming of fields should never have been a client issue to begin with.

redhog commented 8 years ago

Changing the layer name is possible in edit mode. Just click the title and change it.

Question: When no vessel info is available, could we use the series_group value, rather than the index, since that won't get messy if you add and remove multiple layers many times (the same vessel always have the same number)?

redhog commented 8 years ago

As for the color picker, should it set the high and low values to the same value?

enriquetuya commented 8 years ago

@redhog I've updated the description.

enriquetuya commented 8 years ago

@redhog

Conflicting files
js/app/Data/Selection.js

image

redhog commented 8 years ago

I have fixed the conflict. The ellipsis doesn't work due to the dom strcuture and styling of other elements - the animation-title never gets its size restricted, and it's not possible to (easily) do that. If we reworked the styles and used display: table-cell, maybe... I suggest making the sidebar just ever so much wider by default...

enriquetuya commented 8 years ago

@redhog The PR is still in conflict, I think it is due to the latest Categorized Blade merge.

redhog commented 8 years ago

Merged