GlobalFishingWatch / vessel-lists

DEPRECATED: See https://github.com/GlobalFishingWatch/treniformis
Apache License 2.0
2 stars 1 forks source link

Treniformis #28

Closed bitsofbits closed 8 years ago

bitsofbits commented 8 years ago

In progress: DO NOT MERGE

closes: #26, #19

bitsofbits commented 8 years ago

@geowurster, can you take a look at this when you get the chance. pip install . works and there is a UI to get at commonly used lists. I'm paricularly interested in feedback on:

Help on active_mmsis in module treniformis object:

class active_mmsis(__builtin__.dict)
 |  # Active MMSIs 
 |  
 |  MMSIs of vessels which are broadcasting during the specified peroid
 |  
 |  Only MMSIs with a minimum number of positional reports are included
...
geowurster commented 8 years ago

@bitsofbits You need to add .ipynb_checkpoints/ to .gitignore. GitHub's default gitignore for Python is pretty good.

geowurster commented 8 years ago

@bitsofbits Will finish reviewing tomorrow when I have more time. Updating the gitignore will make this a lot easier.

bitsofbits commented 8 years ago

@kevin, thanks for looking things over; I updated .gitignore, translated README and moved the TODO to #30

geowurster commented 8 years ago

Superseded by treniformis, specifically https://github.com/GlobalFishingWatch/treniformis/pull/1.