The Network Development and Deployment Initiative (NDDI), a partnership between Internet2, Indiana University and others was formed to create a new network platform and complementary software, which together will support global scientific research in a revolutionary new way. The Open Exchange Software Suite (OESS) is the first software product to emerge from this partnership. Internet2's 100G nationwide AL2S network is also a product of this effort.
Occasionally, requests to azure for connection details may fail due to timeouts or rate-limits. Failure to account for these error cases resulted in the AzureSyncer believing peers on the connection were removed. Because Azure is the authoritative source for peer definitions, the peers were removed from the connection. Subsequent attempts to sync peers would have recreated these peers assuming no errors encountered. A error check has been added which skips syncing of peers when these errors are encountered.
Occasionally, requests to azure for connection details may fail due to timeouts or rate-limits. Failure to account for these error cases resulted in the AzureSyncer believing peers on the connection were removed. Because Azure is the authoritative source for peer definitions, the peers were removed from the connection. Subsequent attempts to sync peers would have recreated these peers assuming no errors encountered. A error check has been added which skips syncing of peers when these errors are encountered.
An easy fix is to call
nextwhendefined $conn->{error} || defined $conn->{Error}just after https://github.com/GlobalNOC/OESS/blob/master/app/oess_pull_azure_interfaces.pl#L40