Bad logic introduced while limiting logged warnings in entity.cgi

GlobalNOC / OESS

The Network Development and Deployment Initiative (NDDI), a partnership between Internet2, Indiana University and others was formed to create a new network platform and complementary software, which together will support global scientific research in a revolutionary new way. The Open Exchange Software Suite (OESS) is the first software product to emerge from this partnership. Internet2's 100G nationwide AL2S network is also a product of this effort.

http://globalnoc.iu.edu/sdn/oess.html

27 stars 25 forks source link

Bad logic introduced while limiting logged warnings in entity.cgi #1453

Closed jonstout closed 1 year ago

jonstout commented 1 year ago

Logic introduced here had the side effect of limiting some interfaces from being returned in entity.cgi?method=get_entities. The removed interfaces are those with ACLs containing no workgroup restrictions (an undef workgroup_id).

This line is incorrect: https://github.com/GlobalNOC/OESS/blob/master/frontend/webservice/entity.cgi#L477

The correct logic should be:

next if (defined($acl->{'workgroup_id'}) && $acl->{'workgroup_id'} != $workgroup_id);