search

GlobalNamesArchitecture / gnparser

Split scientific names to meaningful elements with meta information
https://parser.globalnames.org/
MIT License
20 stars 2 forks source link

Sometimes warning ids are broken #147

Closed alexander-myltsev closed 8 years ago

alexander-myltsev commented 9 years ago 
org.globalnames.parser.ScientificNameParser.Result = Result(Input(Döringina Ihering 1929 (synonym)),ScientificName(Some(NamesGroup(150,Vector(Name(149,Uninomial(148,org.parboiled2.CapturePos@9,Some(Authorship(147,AuthorsGroup(140,AuthorsTeam(139,Vector(Author(138,Vector(AuthorWord(137,org.parboiled2.CapturePos@1b)),false,None))),None,Some(Year(146,org.parboiled2.CapturePos@4,None,false))),None,false,false)),None,None,false),None,None,None,None,None,None,false)),None)),false,3, (synonym)),Vector(Warning(3,Unparseable tail,150), Warning(2,Non-standard characters in canonical,134)))

Consider rule name3: uninomialWord just dropped in favor of Uninomial with new AST Node id. That means that all warns collected so far for uninomialWord link to wrong AST Node.

alexander-myltsev commented 8 years ago

Fixed by 775498eb0134c18e6b82784900045ecddf16a79a