search

GlobalNamesArchitecture / gnparser

Split scientific names to meaningful elements with meta information
https://parser.globalnames.org/
MIT License
20 stars 2 forks source link

Parsing punctuation when a name is part of a sentence creates more problems than solves. #433

Closed dimus closed 6 years ago

dimus commented 6 years ago

We introduced 'smart stopping' of a parser (#299), when it encounters punctuation from a context in which it was mentioned in a sentence. It looks like this rule created more problems than solved, and it is better to remove it. It means that rules in this section of tests would not be supported anymore:

SECTION: Punctuation in the end<

Melanius: Negalasa fumalis Barnes & McDunnough 1913. Next sentence Negalasa fumalis. Next sentence Negalasa fumalis, continuation of a sentence Negalasa fumalis Barnes; something else Negaprion brevirostris Negaprion brevirostris, the rest of the sentence Negaprion fronto (Jordan and Gilbert, 1882):

alexander-myltsev commented 6 years ago

Would reverting PR https://github.com/GlobalNamesArchitecture/gnparser/pull/302 be enough?