GlobalNamesArchitecture / gnparser

Split scientific names to meaningful elements with meta information
https://parser.globalnames.org/
MIT License
20 stars 2 forks source link

Documentation for canonicalName #480

Closed JRice closed 5 years ago

JRice commented 5 years ago

https://github.com/GlobalNamesArchitecture/gnparser/blob/master/README.rst#getting-the-simplest-possible-canonical-form

...This references names that I am not seeing in the JSON response. Perhaps this is covered in #209 but I thought it would be lower-hanging fruit to just update those strings in the existing docs.

dimus commented 5 years ago

@JRice you probably did not see these names because in Go version of gnparser (they are called CanonicalName->simple and CanonicalName->full in contrast with Scala parser. The reason for chaning was omitting hybrid signs in simple for named hybrids. Many times people omit hybrid sign for named hybrids, and we do want to match Iris germanica and Iris x germanica using simple canonical form. So simple form is for matching purposes, and full form is for presentation purposes. We changed the name because valueRanked now includes named hybrids, and its semantic meaning drifted as a result. I added an issue for Go parser https://gitlab.com/gogna/gnparser/issues/44

dimus commented 5 years ago

Closing it here, as the ticket is related to https://gitlab.com/gogna/gnparser