search

GlobalNamesArchitecture / gnresolver

MIT License
0 stars 0 forks source link

suggest to include fishbase_taxon_cache as name source #52

Closed jhpoelen closed 7 years ago

jhpoelen commented 8 years ago

as discussed with @dimus @alexander-myltsev last wk, I've created a project https://github.com/jhpoelen/fishbase_taxon_cache that generates a fishbase taxon cache that contains all species accessible through sealifebase.org and fishbase.org . Please let me know if there's anything I can do to help include the full taxonomic paths of this resource into global names. I am hoping to start using this data source through your name resolver.

alexander-myltsev commented 8 years ago

Thanks 👍

jhpoelen commented 8 years ago

@dimus thanks for adding the name source 177 Taxon Cache. I've created a first integration with it. Two suggestions: (a) populate the taxon path ids, as far as I can tell the taxon path is populated, but somehow the ids are lost. (b) include a pointer to https://github.com/jhpoelen/fishbase_taxon_cache in source description. This way, the user of the name source can figure out how the names were collected.

If these changes are too much trouble, please feel free to close the issue.

dimus commented 8 years ago

Sounds good Jorrit, I will add your suggestions and then close the issue

On Mon, Jul 25, 2016 at 5:17 PM, Jorrit Poelen notifications@github.com wrote:

@dimus https://github.com/dimus thanks for adding the name source 177 Taxon Cache. I've created a first integration with it. Two suggestions: (a) populate the taxon path ids, as far as I can tell the taxon path is populated, but somehow the ids are lost. (b) include a pointer to https://github.com/jhpoelen/fishbase_taxon_cache in source description. This way, the user of the name source can figure out how the names were collected.

If these are too much trouble, please feel free to close the issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GlobalNamesArchitecture/gnresolver/issues/52#issuecomment-235088191, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvXGSMi-tpdIccgDxj1jhB84zjJk1vks5qZSfugaJpZM4JEtpG .