Globalshala / Eval-Bridge-bugs

In the Repository, we will add the bugs related to eval bridge system
0 stars 1 forks source link

Error message issue in Upload csv #280

Open kartikatyagi opened 1 month ago

kartikatyagi commented 1 month ago

Describe the bug Issue 1: Uploading a CSV file with an invalid column name, such as "AppId" instead of "appId," results in two error messages being displayed.

Issue 2: When uploading a CSV file with one of the required columns (first name, last name, or appId) missing, the displayed error message is not user-friendly. error message if first name column is missing : CSV file missing required fields Missing first name in CSV Missing first name in CSV error message if last name column is missing : CSV file missing required fields Missing last name in CSV Missing last name in CSV error message if appId column is missing : CSV file missing required fields Missing app ID in CSV Missing app ID in CSV

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Upload csv '
  2. Click on choose file.'
  3. Click on submit button
  4. See error

Expected behavior

Issue 1 : There should be only one error message "Invalid column name: AppId" hence the additional error message "Failed to upload a file" should be removed.

Screenshot attached: image

Issue 2: The error message is not user friendly Error message should be like : The CSV file is missing a required field: first name. The CSV file is missing a required field: last name. The CSV file is missing a required field: appId.

Screenshots attached : image

image

image

kartikatyagi commented 1 month ago

Issue 1 working as expected #fixed on dev image

Issue 2 : not working as expected error messages are still not user friendly Screenshots attached : image

image

image

MSGlobalShala commented 1 month ago

@sl-repo can you please check this

shivanim11 commented 1 week ago

Both issues Fixed on dev image