search

GlobbyPotato / Rockhounding_Chemistry

The purpose of Rockhounding Chemistry is to assembly and maintain an industrial area in which several machines handle various types of ingredients (solid, fluid and gaseous) to produce advanced material for mid-late game stages. It also leads to several features, functional applications and experiments.
Other
15 stars 17 forks source link

Sampling Ampoule Bug #152

Open developer-pseudo opened 3 years ago

developer-pseudo commented 3 years ago

This bug has been around for quite awhile, I'm surprised nobody has reported it. Anyways, to reproduce this bug you need a fluidpedia, 1 sampling ampoule, 1 fluid input system. First, you get the sampling ampoule to sample water in the fluidpedia then you put the ampoule in the fluid input system and the sample has suddenly changed to Acrylic Acid or something else. This happens for other gasses/liquids.

Video included: https://gyazo.com/70023afe471fa376767448a0f204678f

GlobbyPotato commented 3 years ago

Hi, I gave a look at it, apparently the bug came in when I added the page splitting to Fluidpedia and came unnoticed since then. The split was being called on both sides so the first slots were always overriden by the material in the A char, hence the acrylic oddity. You may not notice if you pick a fluid from further away slots. I made a quick fix but I have no chance to make a deep test on both client and server so I may flag it a beta for now to see if it works for all. Here the issue disappeared so far.

developer-pseudo commented 3 years ago

Very nice. Thanks for fixing it. I'll close this issue now.

developer-pseudo commented 3 years ago

I just tested it, seems like this time it doesn't set it to acrylic acid, but straight up deletes the NBT data and the sample inside the ampouple.

Primitive-Human commented 3 years ago

Can confirm (pre-beta fix), the only way to properly set the NBT tag on the ampoule was to manually go to each fluid alphabet page using the left/right buttons, just before this feature got added in.

GlobbyPotato commented 3 years ago

It got awkward indeed. noticed the bug returning without doing anything after it was actually gone by testing. will try another way.

developer-pseudo commented 3 years ago

Issue still open since the bug is still around on the newest beta.

This time the sampling ampoules don't even work.

Will post a video soon.

GlobbyPotato commented 3 years ago

Is it the new method to place the ampoule in the slot? I think the issue was in sync between client and server due to the operation being splitted between gui and container.