search

GlobbyPotato / Rockhounding_Chemistry

The purpose of Rockhounding Chemistry is to assembly and maintain an industrial area in which several machines handle various types of ingredients (solid, fluid and gaseous) to produce advanced material for mid-late game stages. It also leads to several features, functional applications and experiments.
Other
15 stars 17 forks source link

[Suggestion] Let the Toxic Sludge FluidBlocks to be able to spawn in any replaceable block #167

Closed gatoborrachon closed 2 years ago

gatoborrachon commented 2 years ago

What is happening you can by-pass the negative effect of pollutants in Fluid Tanks that are surrounded by soft blocks like Grass or Snow (and i guess that any block that isn't air, as this line suggest)

Screenshots +Fluid Tanks filled with Nitric Acid that are not spawning Toxic Sludge. 2021-09-18_17 33 29

+Fluid tanks in a clean area spawning Toxic Sludge 2021-09-18_17 33 37

Suggestion 1.- Be able to spawn these FluidBlocks of ToxicSludge in every soft block (like the previously described) 2.- Or, if you consider it better, maybe it could be added a config option where the user can add the blocks that can be replaced by the Toxic Sludge, with the Grass and the Snow as default (in case you choose this one, consider blocks with metadata)

Additional Notes i noticed about this while i was testing the IToxic Interface in the FluidTanks of another mod

GlobbyPotato commented 2 years ago

Hi, previously the pollutant spawning was less forgiving, I turned into this to make sure it did not create awkward situations, expecially with redstone lying around, to avoid floating spawning or in case of particular replaceable modded blocks. Tinkering the factory with carpets or soft blocks was already considered as a trick. Will see eventually if to set a config to chose between a hard or safer way.

gatoborrachon commented 2 years ago

oh, ok, i think the last option (adding a config to choose between hard/easy hazard features) would be the best, thanks for answer, and yeah, it would be nice to affect modded replaceable blocks too

GlobbyPotato commented 2 years ago

I made a quick fix on the fly to see how it works. I made sure any isReplaceable() occurrency I found is checked. Also added a config to change the radius of the polluting area.

gatoborrachon commented 2 years ago

ok, let me test it in some hours and i will close the issue, many thanks

gatoborrachon commented 2 years ago

Works pretty fine, many thanks 2021-09-20_21 42 03