search

GlobeHoppin / globe-hoppin-backend

Backend of GlobeHoppin. Tech - NodeJs, Express and MongoDB
https://www.api-globehoppin.mustafizkaifee.in/
5 stars 11 forks source link

added contact form Api issue #16 #17

Closed AyushSharma72 closed 5 days ago

AyushSharma72 commented 1 week ago

added a contact form Api which enable you to get user messages on mail

api

you will recieve messages like this on your mail id mustafizkaifee04@gmail.com

check out the frontend repo modifications for this api frontend PR

AyushSharma72 commented 6 days ago

please review the latest commit requested changes

Mustafiz04 commented 5 days ago

Can you please squash all 3 commits into 1 commit ?

AyushSharma72 commented 5 days ago

Can you please squash all 3 commits into 1 commit ?

ok let me do it the rest is fine ??

AyushSharma72 commented 5 days ago

Can you please squash all 3 commits into 1 commit ?

ok let me do it the rest is fine ??

please check @Mustafiz04

Mustafiz04 commented 5 days ago

Please squash and write the correct commit message. I am asking this so it helps us track work correctly.

AyushSharma72 commented 5 days ago

Please squash and write the correct commit message. I am asking this so it helps us track work correctly.

yes was about to do thaty

AyushSharma72 commented 5 days ago

Just one change, rest look good.

ok please wait so i will make the subject to the email title and remove it form the fields ??then we will have only two fields the email and the messages ?? or i keep the subject in the fields as well ???

Mustafiz04 commented 5 days ago

ok please wait so i will make the subject to the email title and remove it form the fields ??then we will have only two fields the email and the messages ??

We should only have a message. Right now your code sends emails in plain text, you can also explore sending an email template using EJS or something. It will send emails professionally and look good. I hope you got what I am saying. https://ejs.co/

AyushSharma72 commented 5 days ago

ok please wait so i will make the subject to the email title and remove it form the fields ??then we will have only two fields the email and the messages ??

We should only have a message. Right now your code sends emails in plain text, you can also explore sending an email template using EJS or something. It will send emails professionally and look good. I hope you got what I am saying. https://ejs.co/

what should i do now ? remove the subject right ejs and template i will explore later sir may be in other issue thankyou for sharing your experience

Mustafiz04 commented 5 days ago

Follow this to squash commits -- https://github.com/GlobeHoppin/globe-hoppin-backend?tab=readme-ov-file#note

Mustafiz04 commented 5 days ago

ok please wait so i will make the subject to the email title and remove it form the fields ??then we will have only two fields the email and the messages ??

We should only have a message. Right now your code sends emails in plain text, you can also explore sending an email template using EJS or something. It will send emails professionally and look good. I hope you got what I am saying. https://ejs.co/

what should i do now ? remove the subject right ejs and template i will explore later sir may be in other issue thankyou for sharing your experience

Yeah remove the subject and create a follow-up issue to use the EJS template and work on it.

AyushSharma72 commented 5 days ago

ok please wait so i will make the subject to the email title and remove it form the fields ??then we will have only two fields the email and the messages ??

We should only have a message. Right now your code sends emails in plain text, you can also explore sending an email template using EJS or something. It will send emails professionally and look good. I hope you got what I am saying. https://ejs.co/

what should i do now ? remove the subject right ejs and template i will explore later sir may be in other issue thankyou for sharing your experience

Yeah remove the subject and create a follow-up issue to use the EJS template and work on it.

before that will you merge this please ??

AyushSharma72 commented 5 days ago

done ! please merge now 🙏🙏also check the frontend code https://github.com/GlobeHoppin/GlobeHoppin/pull/11

Mustafiz04 commented 5 days ago

Everything look good but please merge both commit into one. There are still 2 commits showing.

Let me know if you are not able to squash.

It is good practice to have only 1 commit per PR.

AyushSharma72 commented 5 days ago

Everything look good but please merge both commit into one. There are still 2 commits showing.

Let me know if you are not able to squash.

It is good practice to have only 1 commit per PR.

I will try again

AyushSharma72 commented 5 days ago

Everything look good but please merge both commit into one. There are still 2 commits showing. Let me know if you are not able to squash. It is good practice to have only 1 commit per PR.

I will try again

completed only one commit now please check the cod eon the frontend also https://github.com/GlobeHoppin/GlobeHoppin/pull/11 and will you mark this pr level3 ??

AyushSharma72 commented 5 days ago

How this will work with out frontend please check GlobeHoppin/GlobeHoppin#11