search

Globox1997 / BackSlot

https://modrinth.com/mod/backslot
https://www.curseforge.com/minecraft/mc-mods/backslot
GNU General Public License v3.0
9 stars 12 forks source link

[Bug & Mini Request] Mod Compatibility Config Bug #10

Closed ZaneDragonBorn closed 1 year ago

ZaneDragonBorn commented 3 years ago

So There seems to still be a repeated issue no matter what I do (Uninstalling, restarting the game, etc). The Back Slots are only interactable from their original Position. Aka the Mod Compatibility feature only moves the icons but not the interaction points, as seen below. I have followed the instruction that says to restart to enable this feature. image

Now on to the Request Please link the issues page in Mod Menu.

Globox1997 commented 3 years ago

That's super weird cause I can't reproduce this bug in a singleplayer world. does this happen only in multiplayer or does it also happen when you have only backslot installed?

ZaneDragonBorn commented 3 years ago

This happened in Singleplayer (Can't test in Multiplayer) and I was playing with it with like 290+ mods. The Mods that may cause this issue are Trinkets and Curios API. Otherwise, I don't see any other causes

Globox1997 commented 3 years ago

I tested with the newest curios api + trinkets + bunch o trinkets and everything worked fine. I have used this "new" version of backslot where I just updated the networking which shouldn't change any compat so I have no idea what could cause this bug. There has to be another mod which causes trouble, anything you could think of? This is the version I used: backslot-1.1.9.zip

ZaneDragonBorn commented 3 years ago

I'll try it now

ZaneDragonBorn commented 3 years ago

image Nope seems like it doesn't work. I can't think of anything else that would cause this

Globox1997 commented 3 years ago

to be clear, you are not asking for a inventory sorting compatibility, the green + the handslot are the slots where the weapons will get displayed when they should get displayed next to (right of) the recipe book?

ZaneDragonBorn commented 3 years ago

to be clear, you are not asking for a inventory sorting compatibility,

In this issue, I'm not asking for Compatibility. I'm asking for a bug fix. I have no idea what would cause this though. the Only mods I can think of that may be Trinkets, Curios, Inventory Profiles, Inventory Tabs, and Inventory Sorting

he green + the handslot are the slots where the weapons will get displayed when they should get displayed next to (right of) the recipe book?

yes

Globox1997 commented 3 years ago

They only way to find out which mod makes trouble is to check every single one...

ZaneDragonBorn commented 3 years ago

Yeah, I know that. That's why I said the ones I believe may be the cause.

Globox1997 commented 3 years ago

I've tested rinkets, Curios, Inventory Profiles, and Inventory Sorting on 1.16.5 and still, everything worked fine so far Inventory Tabs isn't available on this mc version

RyanCR03 commented 3 years ago

im using latest version of the mod on 1.16.4 and having a similar problem, so it might be that

IdrisQe commented 3 years ago

I'm getting this issue as well. I'm using Trinkets. Just installed Bunch O' Trinkets (the glove slot intersecting is what made me toggle the feature in the first place) and it didn't work correctly. After removing a bunch of mods- surprisingly, the ones I thought wouldn't cause any issues, the problem resolved itself in my test instance. After adding back the mods, the issue resumed. I removed... Quite a few, so I'm going to do some more testing and searching through the logs...

IdrisQe commented 3 years ago

EDIT AGAIN: Okay so on a hunch, I loaded up the pack again with all the aforementioned mods. Glitch happened. I removed the smallest, most completely irrelevant mod from my pack... The glitch didn't happen. I replaced said small, inconsequential mod with another tiny mod that I had already determined wasn't causing the problem. The glitch happened again. My crackpot theory about it somehow relating to the number of mods being loaded is actually starting to seem scarily sane... For reference, the error consistently occurs when there are 97+ mods in my mods folder. In the ModMenu Fabric says there are 98 mods loaded. The error does not seem to ever occur when there are 96 or fewer mods in the folder. I swear, the data is backing this up. I don't know WHY. I wish it wasn't.

EDIT i give up: Removing even just one of EnchantmentDescriptions, Enhanced Attack Indicator, EntityCulling, or ExtraAlchemy fixes the problem, apparently. At this point I honestly don't know if it's just happening randomly and I'm pulling data out of my ass or something because I feel like I'm bashing my head against a brick wall. Maybe it has something do do with a certain AMOUNT of mods getting loaded??? Even though that makes no sense. It makes just about as much sense as any of this nonsense. I legitimately can't handle this any longer. It's 2:30 in the morning and I'm not even a smidgeon closer to figuring out the problem. I'd honestly just ask to send the pack somehow so it can get opened in a development environment where the source of the issue might maybe be gleamed or something because I am making no progress...

EDIT 6 i guess???: So keeping Adorn, CPAS, Crowmap, Crumbs, and CullLeaves... Removing all of, or some combination of: DarkPaintings, Desolation, Direbats, DualRiders, DynamicSoundFilters Seems to resolve the issue... For... Some reason. I tried a bunch of combos of the "D" mods but I still can't figure out the cause... This makes no logical sense???

EDIT 5: Okay I'm beginning to think the game is messing with me... With Adorn, removing some combinations of CPAS, Crowmap, Crumbs, and CullLeaves fixes the issue, but having all of them seems to keep the problem... Unless I remove certain other mods, which also solves the issue??? I'm totally lost here.

EDIT 4: Confirmed the first piece of the problem: Adorn. No idea what Adorn would be causing problems with... But it seems to be partially responsible. I still don't know what other mod it's interacting with to cause such an issue, however. More testing is needed.

EDIT 3: ...I broke my entire modlist into 5 chunks, tested each of them seperately, and the issue didn't occur, which means it's some issue between mods in two of those 5 chunks. Helpful? Not really... But progress...

EDIT 2: After 20+ minutes of further testing, I thought I had it narrowed down to one of a few mods but it turns out it wasn't any of them? Annoyingly, this is probably a multi-mod conflict... It's getting late so I may not do further testing tonight.

EDIT: The below is not the cause. Moving on with testing...

This may be the cause? Not sure. It's definitely one of the more notable errors on loading, and mentions entity equipment (inventory?) as well as shifting, which sounds like the kind of thing moving the locations would do. Can't figure out what mod is causing it so this will be some trial and error...

[23:34:38] [main/WARN]: @Inject(@At("INVOKE")) Shift.BY=2 on modid.mixins.json:events.MixinLivingEntity::handler$zke000$entityEquip exceeds the maximum allowed value: 0. Increase the value of maxShiftBy to suppress this warning.
java.lang.ClassNotFoundException: Not Enough Crashes deobfuscated stack trace
    at java.net.URLClassLoader.findClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at net.fabricmc.loader.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:168)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at java.lang.Class.forName0(Native Method)
    at java.lang.Class.forName(Unknown Source)
    at fudge.notenoughcrashes.stacktrace.ModIdentifier.identifyFromClass(ModIdentifier.java:74)
    at fudge.notenoughcrashes.stacktrace.ModIdentifier.identifyFromThrowable(ModIdentifier.java:49)
    at fudge.notenoughcrashes.stacktrace.ModIdentifier.lambda$identifyFromStacktrace$0(ModIdentifier.java:26)
    at fudge.notenoughcrashes.stacktrace.ModIdentifier.visitChildrenThrowables(ModIdentifier.java:31)
    at fudge.notenoughcrashes.stacktrace.ModIdentifier.identifyFromStacktrace(ModIdentifier.java:26)
    at net.minecraft.class_128.md3da566$lambda$afterFillSystemDetails$0$0(class_128.java:1070)
    at net.minecraft.class_129.method_577(class_129.java:79)
    at net.minecraft.class_128.handler$bgb000$afterFillSystemDetails(class_128.java:1068)
    at net.minecraft.class_128.method_559(class_128.java:65)
    at net.minecraft.class_128.<init>(class_128.java:37)
    at net.minecraft.class_128.method_24305(class_128.java:302)
    at net.minecraft.client.main.Main.main(Main.java:135)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:226)
    at net.fabricmc.loader.launch.knot.Knot.launch(Knot.java:146)
    at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:28)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196)
    at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231)
    at org.multimc.EntryPoint.listen(EntryPoint.java:143)
    at org.multimc.EntryPoint.main(EntryPoint.java:34)
java.lang.ClassNotFoundException: net.minecraft.util.crash.CrashReport
    at java.net.URLClassLoader.findClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at net.fabricmc.loader.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:168)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at java.lang.Class.forName0(Native Method)
    at java.lang.Class.forName(Unknown Source)
    at fudge.notenoughcrashes.stacktrace.ModIdentifier.identifyFromClass(ModIdentifier.java:74)
    at fudge.notenoughcrashes.stacktrace.ModIdentifier.identifyFromThrowable(ModIdentifier.java:49)
    at fudge.notenoughcrashes.stacktrace.ModIdentifier.lambda$identifyFromStacktrace$0(ModIdentifier.java:26)
    at fudge.notenoughcrashes.stacktrace.ModIdentifier.visitChildrenThrowables(ModIdentifier.java:31)
    at fudge.notenoughcrashes.stacktrace.ModIdentifier.identifyFromStacktrace(ModIdentifier.java:26)
    at net.minecraft.class_128.md3da566$lambda$afterFillSystemDetails$0$0(class_128.java:1070)
    at net.minecraft.class_129.method_577(class_129.java:79)
    at net.minecraft.class_128.handler$bgb000$afterFillSystemDetails(class_128.java:1068)
    at net.minecraft.class_128.method_559(class_128.java:65)
    at net.minecraft.class_128.<init>(class_128.java:37)
    at net.minecraft.class_128.method_24305(class_128.java:302)
    at net.minecraft.client.main.Main.main(Main.java:135)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:226)
    at net.fabricmc.loader.launch.knot.Knot.launch(Knot.java:146)
    at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:28)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196)
    at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231)
    at org.multimc.EntryPoint.listen(EntryPoint.java:143)
    at org.multimc.EntryPoint.main(EntryPoint.java:34)
Globox1997 commented 3 years ago

First of all it's quite entertaining to read your comment @IdrisQe :D I don't know where you are from but I usually read from top to bottom not the other way around xD Why do you have so many mods installed :D however, the number of mods shouldn't affect anything.

IdrisQe commented 3 years ago

Well I put edits at the top when they're important and... I just sort of kept adding edits. Canada, though. And as for all the mods, because I have a serious problem whenever I'm making a modpack, I throw in EVERY mod I MIGHT want to use, and about 50 mods that only tweak one thing very slightly >.>;; and about 20 performance tweak mods...

IdrisQe commented 3 years ago

Honestly though I feel like my modpack is cursed. I remove one more mod to push me over that point, ANY mod, and the glitch with BackSlot's config stops happening. I add one more mod back, ANY mod, and it starts happening again. I don't understand it. At this rate I might just remove BackSlot... Or maybe I'll just remove Bunch of Trinkets since it's where the slot's getting overlaid in the first place... Hmm... I do really want to use BackSlot... Hmmm...

Well either way that can wait for tomorrow I spent 4 hours trying to debug this mess and it's 3:33 AM and i'm sleep deprived so yes

i hope this gets fixed, somehow, or that the cause is figured out, because ... i just want to know what it is at this point, frankly

Globox1997 commented 3 years ago

oh nice canada :D I would say, remove backslot cause I don't think I will find out what causes this bug since you already tried to locate incompatibilities but couldn't fit it. Maybe in a future version, it's magically fixed^^

Globox1997 commented 3 years ago

backslot-1.1.10-test.zip The only thing I can think of is this - changed the mixin injection point inside the PlayerScreenHandler class for the initialization method. You have to unzip it if you test it out

IdrisQe commented 3 years ago

.......... image It worked.

Excuse me while I faceplant my desk because oh my gosh- THANK YOU!

EDIT: Uhhh... Well, okay, it did fix that... But that seems to have caused a new issue: I can't interact with the default slots Trinkets are based off of for some reason. They don't highlight, and you can't click them to put armour on/take armour off. The Trinket slots themselves still work fine though? gif ...and CPAS is also having some pretty big issues now suddenly. Heck. Can't click Helmet slot... But when I click Pants slot it acts as if I'd clicked the Helmet slot. If I put a Helmet in the Helmet slot it vanishes... and appears in the inventory crafting grid??? gif image EDIT 2: Confirmed removing Backslot fixes both of these new issues.

Globox1997 commented 3 years ago

xD... I just tested other things and I didn't get good results. In my estimation I will not be able to solve the problem. And I guess, too many mods could lead to different loading times which could change the load order of mods which actually doesn't make real sense but thats the only thing I can think of could cause the mod counting thingy.

IdrisQe commented 3 years ago

Honestly I have no idea what it could be at this point. I just decided to remove Bunch of Trinkets and, in the old version of BackSlot, set the config back to normal. Without the Trinkets glove slot there's no overlap, so it's fine! Besides, I probably wasn't going to use most of the BoT Trinkets upon inspection.

Still annoyed I couldn't figure out what was causing the issue though... Oh well. Thanks for testing things to try and fix it though, even though there was basically no concrete evidence as to the cause!

Globox1997 commented 3 years ago

I would also like to figure out what causes this bug :D Thank you too for testing stuff out!

IdrisQe commented 3 years ago

I hope you manage to figure it out somehow! It's an odd one for sure >.> Interestingly I came across another bug with another mod that seemed to just... go away when I removed a certain number of mods, regardless of which ones it was. Unless it was a bug caused by interactions involving 38 different mods which I highly doubt >.>;;;;

MissGamerz commented 3 years ago

@Globox1997 would you like to join our discord il send you our modpack MMC version that i use for testing and this has a 100% recreation of this bug

Globox1997 commented 3 years ago

Thanks for the offer but I don't wanna spend time to figure something out which probably takes a tremendous amount of time. If your modlist is short, please post it here :) I don't use MMC so I will just download them and test it on the vanilla launcher

MissGamerz commented 3 years ago

its not short

Globox1997 commented 3 years ago

Mh, as the comments in this Issue say, it's a multi mod problem which is basically much harder to fix than other bugs/incompatibilities. Hope you understand my statement. If you can localize it on a specific mod, I would give it another try

Globox1997 commented 3 years ago

Added advanced slot moving settings, this may help for compat issue https://github.com/Globox1997/BackSlot/commit/2be53542f4c5661c9aa0f62ca2ead97e6a1e01af

Globox1997 commented 1 year ago

If this still happens on the latest version, reopen this issue.