search

Globox1997 / BackSlot

https://modrinth.com/mod/backslot
https://www.curseforge.com/minecraft/mc-mods/backslot
GNU General Public License v3.0
9 stars 12 forks source link

[1.18.1] Adding items to backslot via datapack and item scaling #57

Closed lizfinite closed 2 years ago

lizfinite commented 2 years ago

This is more of a feature request than a bug, but after adding SurvivalPlus's lightsabers in my mod pack to belt slots via a datapack, I noticed that for certain items the scale can be quite off. However adjusting the scaling options present in the mod config obviously apply to all items so you either have to make the trade off for small swords or big lightsabers.

Default Scaling (2.0): 2022-01-11_18 15 04 2022-01-11_18 15 07 1.0 Scaling: 2022-01-11_18 15 30 2022-01-11_18 15 39

Is there a way to resize items beltslot/backslot via the datapack? If not, it would be nice to be able to do so. However that might also be asking quite a lot/the impossible for what datapacks can do.

So then, would it be possible to compensate with a resourcepack somehow? By changing the json of the model? I know you can scale it up in the hand vs on the ground or in an item slot, but I'm not sure how this one scales since the saber is different in all those situations from the size it is on my belt currently.

Thanks for exposing it to data to make it work for adding additional items though, that's already really neat :smile:

Globox1997 commented 2 years ago

I guess we can close this issue with your PR #62 as a reference :D thanks again!