search

Globox1997 / BackSlot

https://modrinth.com/mod/backslot
https://www.curseforge.com/minecraft/mc-mods/backslot
GNU General Public License v3.0
9 stars 12 forks source link

Items drop with Grave mod #75

Closed Kuggle01 closed 2 years ago

Kuggle01 commented 2 years ago

Items in the backslots will still drop on the ground with this grave mod https://www.curseforge.com/minecraft/mc-mods/youre-in-grave-danger

Globox1997 commented 2 years ago

At https://github.com/B1n-ry/Youre-in-grave-danger/blob/1.18.2/src/main/java/com/b1n_ry/yigd/mixin/LivingEntityMixin.java#L58 the items get added to the grave item list and since in the PlayerInventory class only those three "main, armor, offHand" are public instead of the "combinedInventory" (where BackSlot adds its items) which contains all three of these :/

My guess is that an AW onto the combinedInventory would work fine and then this can be used.

Globox1997 commented 2 years ago

Added better compat with other grave mods. yigd with https://github.com/Globox1997/BackSlot/commit/f3f3aef39f18f2be844d1badb67d8c7caca50069 It looks like the different grave mods just copied the same code xD Except for https://www.curseforge.com/minecraft/mc-mods/universal-graves, this one works perfectly fine. The compat I have with all other gravestone mods is not perfect since they don't use the combined inventory field (which is private, could be changed with an AW)

Bad compat: https://www.curseforge.com/minecraft/mc-mods/youre-in-grave-danger https://www.curseforge.com/minecraft/mc-mods/gravestones https://www.curseforge.com/minecraft/mc-mods/charm (preserving totem) Good compat: https://www.curseforge.com/minecraft/mc-mods/universal-graves