search

Globox1997 / BackSlot

https://modrinth.com/mod/backslot
https://www.curseforge.com/minecraft/mc-mods/backslot
GNU General Public License v3.0
9 stars 12 forks source link

My world unload when press any keybind from the mod with Immersive Portals installed #99

Closed Landrozaum closed 1 year ago

Landrozaum commented 1 year ago

Minecraft 1.19.2 Fabric 0.14.12 Fabric API 0.72.0 Mod Version 1.2.11.1

Issue: When i am with Immersive Portals installed, and i try press the backslot or the beltslot keybind, my world unloads, and the game go to the main menu screen, i enter in the world and the item goes to the back slot but obviously, everytime the world unloads.

This is what is showed to me: javaw_31e2H1hzk2

Landrozaum commented 1 year ago

surprised that immersive portals itself takes the blame away from him, and yes, i tried to play with immersive portals and without and everything goes well

qouteall commented 1 year ago

https://github.com/iPortalTeam/ImmersivePortalsMod/issues/1323

qouteall commented 1 year ago

@Landrozaum Immersive Portals is just checking threads and because it seems that backslot is trying to send packet in non-server thread and sending packet in non-server thread is unsafe even without Immersive Portals.

qouteall commented 1 year ago

I have to clearify that ImmPtl is just doing thread checking for ease of debugging (it indeed found a thread safety issue of backslot) so it's technically not ImmPtl's fault.

https://github.com/Globox1997/BackSlot/issues/107

qouteall commented 1 year ago

The next version of ImmPtl will not make the checking strict to reduce misunderstanding.

Globox1997 commented 1 year ago

Fixed unsafe handling with https://github.com/Globox1997/BackSlot/commit/fec26b685f7a9bef92efc12bb66f3ad814a969e4