search

Globox1997 / Dehydration

https://modrinth.com/mod/dehydration
https://www.curseforge.com/minecraft/mc-mods/dehydration
GNU General Public License v3.0
21 stars 22 forks source link

Purified water is considered equal to plain water #126

Closed TropheusJ closed 10 months ago

TropheusJ commented 1 year ago

Minecraft Version

1.19.x

Mod Loader Version

loader 0.14.19, API 0.73.2+1.19.2

Mod Version

1.3.4

Describe the Issue

WaterFluidMixin makes plain water match purified water here.

This is causing Create's filling recipes using water to break. See the original issue here for details: https://github.com/Fabricators-of-Create/Create/issues/983

Plain water is matching the purified water, magically converting it when filling.

latest.log

note: from a dev env https://gist.github.com/TropheusJ/5a57fdf4726068040ff91032104d138e

Do you use any other mods except the required ones?

Create

Globox1997 commented 1 year ago

This mixin is required for a couple reasons not sure what would happen if I disable it when Create is loaded? But I guess this is the only fix?

Globox1997 commented 10 months ago

Added a create check with https://github.com/Globox1997/Dehydration/commit/25336a68be08e440d2813651fd2e0b6a2c6c210e This should fix the issue.