search

Globox1997 / Dehydration

https://modrinth.com/mod/dehydration
https://www.curseforge.com/minecraft/mc-mods/dehydration
GNU General Public License v3.0
21 stars 22 forks source link

[Enhancement] Bamboo Pump Rework #158

Open Cicopath opened 7 months ago

Cicopath commented 7 months ago

Make sure you are not opening a duplicate.

Description of your suggestion.

Right now, the bamboo pump can provide infinite amounts of purified water. In fact, if you want a free water source on the go, just bring a bamboo pump or two with you and you can easily fill your glass bottle, flask, or whatever purified water-holding item. Hell, it even works in the Nether?!

Instead of having the bamboo pump provide infinite amounts of water, why not make it act like a well? If there is water at most a few blocks under the block below the bamboo pump, the bamboo pump will take that source of water and deliver it to your flask all purified.

Of course, not everybody may enjoy this new feature. I would highly suggest adding a configuration option for people who preferred the current, water block-free mechanic of the bamboo pump. But at least make it disabled in the Nether, or maybe add biome/dimension tags in which the bamboo pump cannot function. Basically, if there is a modded biome or dimension in which water cannot be placed, players can make it so the old functionality of the bamboo pump will not work in them via a data pack.

creeloper27 commented 6 months ago

I second everything that is proposed, this is exactly what I expected when I realized there was a pump in this mod, It's very unbalanced right now, it feels wrong to use it in the current state, I end up just placing this down, filling my flask, breaking it (which resets the cooldown also!) and repeating, at least having to keep a water bucket or more with you would probably feel more fair. If this gets implemented the cooldown could also get removed.

creeloper27 commented 6 months ago

Another thing that would work better overall I think is making the pump simply pump normal water into adjacent liquid tanks (from other mods) to stock up on it.

ktorres08 commented 6 months ago

Have you checked the configs for this mod? There is already an option to make the pump require underground water, within 10 blocks. It works in my game; the pump won't work at all if there isn't water underground. Pump Required Water

creeloper27 commented 6 months ago

Have you checked the configs for this mod? There is already an option to make the pump require underground water, within 10 blocks. It works in my game; the pump won't work at all if there isn't water underground. Pump Required Water

Oh, that makes me super silly for not seeing that entry before, thanks a lot for the info!

creeloper27 commented 6 months ago

Another thing that would work better overall I think is making the pump simply pump normal water into adjacent liquid tanks (from other mods) to stock up on it.

I have updated this comment, this would be a nice addition to the pump instead then.

Globox1997 commented 6 months ago

I fixed the cooldown with https://github.com/Globox1997/Dehydration/commit/233b896b4e19c91458c57e3c525f0d067082da3b. The feature to pump liquid in tanks is a good idea, just don't have time for stuff like this lately.

Cicopath commented 6 months ago

Oh I didn't realize this was already a feature! Thank you for the info!

For the base functionality, are you planning on keeping the bamboo pump functional in the Nether?