search

Globox1997 / Dehydration

https://modrinth.com/mod/dehydration
https://www.curseforge.com/minecraft/mc-mods/dehydration
GNU General Public License v3.0
16 stars 21 forks source link

Adds Compatibility and fixes a Bug or more #170

Closed ColinBashful closed 6 days ago

ColinBashful commented 6 days ago

I've added compatibility with BucketLib, and now Dehydration depends on it 'cause it wouldn't work otherwise. There still is one thing that doesn't work: you can't interact with the Copper Cauldron with any UniversalBucketItem due to the behaviorMap taking Items and you can't add instanceof UniversalBucketItem there.

I've fixed a bug where the Thirst Hud would still be visible even when in spectator. There also seemed to be a bug where the game would crash when something gets the potion color, so I just made a null check.

cech12 commented 6 days ago

I think, adding BucketLib as dependency is a really hard way to add the compatiblity^^ Using the FluidStorage system of Fabric would be a more suitable way and enhance the mod to be more compatible with other mods that add FluidStorages as well. :)

ColinBashful commented 6 days ago

I'll try using FluidStorage if possible

ColinBashful commented 6 days ago

I think, adding BucketLib as dependency is a really hard way to add the compatiblity^^ Using the FluidStorage system of Fabric would be a more suitable way and enhance the mod to be more compatible with other mods that add FluidStorages as well. :)

Do you know how I may get the fluids contained in things using FluidStorage? Or how I may change them?

ColinBashful commented 6 days ago

Well, now I'm trying to make BucketLib optional