Globox1997 / Dehydration

https://modrinth.com/mod/dehydration
https://www.curseforge.com/minecraft/mc-mods/dehydration
GNU General Public License v3.0
19 stars 22 forks source link

MAJOR/Minor Issues I've Explored Through And Out Covering All Of The Items Pertinent #185

Open Rhaptein opened 1 month ago

Rhaptein commented 1 month ago

Minecraft Version

1.21.x

Mod Loader Version

1.15.11

Mod Version

1.3.6+1.21

Describe the Issue

Major Issues I found; -Taking purified water bottle from brewing stand COMPLETELY crashes the game. Just by taking the bottle out and closing your inventory kills your game. -Incompatability with Auto HUD by Crendgrim. Something to do with the hud thirst bar I think it's something to do on their part but had to mention this issue as it crashes upon loading into a world.

Some minor issues/inconveniences I've encountered are; -Taking down the campfire cauldron by hand vanishes. I think it should give the item back and similar to as a piston. -Right clicking purified water in the campfire cauldron in creative, doesn't give the purified bottle. -Placing purified water on the ground doesn't turn back to normal water block. -EMI mod doesn't recognize the campfire recipe, nor the world interaction recipe for the water bowls. I've seen the mod no punching tree be able to implement that in. -Drinking the purified water bottle and just water bottle doesn't work for some reason, the thirst bar predicts it's added amount but doesn't add it. So far only flask has been working for me. -Flask doesn't have lore Shift Click on Water to Empty. -Placing purified water in regular cauldron turns into water. -Taking purified water that came from a purified water bucket that's in a copper cauldron doesn't go into flask, Only the purified water can go into flask if made from the campfire cauldron. -Taking regular water from copper cauldron doesn't work, but placing does. -Placing purified water back into campfire cauldron doesn't place. And I think it should evaporate after a while. -Placing dirty water into campfire cauldron from a flask doesn't place. Should turn into impurified water when boiled. -Thirst HUD shows in spectator mode.

Other than that here's some feedback; -Best thirst mod I've found, I love your customizability with it and flasks that go along as the cherry on top. Thank you for that. Does need a little fixing here and there but awesome stuff. -I'd like if there was an effect named sickness where there's a good chance you get it when drinking dirty water. When you have it you take 0.25 Damage every second for a duration of 32 seconds. About so of that. -Taking water from purified water block on the ground gives you water which is fine but I wonder if you could add a way to detect cleanliness of a surface before turning back into a water block and or actually preserving its purified water if its a clean surface the water is in. Bit advanced there. -Currently there's no updated patchouli mod pertinent for this version can't read the info. Maybe add an info tab into the config?

On another note I'd like it if you'd considered changing these default values which are the; -Hydrating Factor :to 2 -Pump Requires Water :to Yes -Water Boiling Time :to 250 I figured these make more sense

latest.log

crash-2024-07-26_16.42.07-client.txt latest.log

Latest log; loading into world is fine until the moment I pulled out the bottled potion in LINE1353

Do you use any other mods except the required ones?

EMI, Lithium, Mod Menu

Globox1997 commented 1 month ago

Hey Rhaptein, thank you very much for this feedback, I am always looking for such high quality feedback, appreciate it a lot!

My thoughts on your minor things: -The campfire cauldron is based on the cauldron which can not be broken by hand (wont drop). -Placing purified water will get dirty when in contact with normal water. -Pls open a github issue with EMI compat cause rn I work on other projects. -Flask can be emptied while sneaking and right clicking on water. -Placing purified water in regular cauldron will turn into dirty water cause the cauldron is "dirty". -Thirst HUD shows in spectator mode - fixed by somebody else in the update