search

Globox1997 / LevelZ

https://modrinth.com/mod/levelz
https://www.curseforge.com/minecraft/mc-mods/levelz
GNU General Public License v3.0
51 stars 50 forks source link

Inventorio Compatibility, Toggle Inv Button #135

Closed Edrow-6 closed 2 years ago

Edrow-6 commented 2 years ago

Update 1.3.2

Added Inventorio Compatibility (with button fallback corresponding to inventory type "default" and "inventorio") image

Added a config to toggle inventory button (toggle in both gui) image

Added missing comment in config file image

Fix typo and update Readme

Globox1997 commented 2 years ago

hey Edrow-6, this looks pretty good even tho the mod Inventorio looks pretty odd in my opinion. Not sure why you are using assertions, feels kinda weird but except of the Inventorio mentioning at the readme it is dope.

Globox1997 commented 2 years ago

I feel like if inventorio compat is mentioned, other compatibilities should be mentioned too but since I don't do that, I'm against it

Edrow-6 commented 2 years ago

Hi, i use assertions because this.client and this.client.player may produce "NullPointerException". ex: image

Edrow-6 commented 2 years ago

I removed the mention in the readme :D

Globox1997 commented 2 years ago

Thanks :) Never saw assertions to be honest^^

Globox1997 commented 2 years ago

Houston Houston we got a problem. If inventorio isn't loaded outside of dev env, the game will crash due to a class not found error: java.lang.NoClassDefFoundError: me/lizardofoz/inventorio/client/ui/InventorioScreen https://github.com/Globox1997/LevelZ/blob/1.18/src/main/java/net/levelz/gui/LevelzScreen.java#L84