Globox1997 / LevelZ

https://modrinth.com/mod/levelz
https://www.curseforge.com/minecraft/mc-mods/levelz
GNU General Public License v3.0
51 stars 50 forks source link

Interacting with the enchanting table crashes the game #169

Open reMarce opened 2 years ago

reMarce commented 2 years ago

Exit code: -1 Placing an item in any slot of the enchanting table makes the game crash and moving the mouse over the button "?" also does. Minecraft version 1.18.2 (fabric) Levelz 1.3.3

Globox1997 commented 2 years ago

can you post the crash log here?

DedicatedMedic commented 2 years ago

I combined the related files from the 1.19 mc, 1.3.6 mod files. The crash is fixed when placing an item, the crash on hovering the helper tooltip remains. Attached are three logs from crashes. I personally have many other mods however so an incompatibility is also possible, I am simply too stubborn to remove LevelZ though as I enjoy the mod.

2022-07-27-7.log.gz 2022-07-27-6.log.gz

EDIT: Clarifying that I am also running 1.18.2 LevelZ 1.3.3. I simply opened the jar to combine the enchantment mixins from the newer version as the patch notes implied they had a fix.

Globox1997 commented 2 years ago

Yes there is no null check in the screen class here https://github.com/Globox1997/LevelZ/blob/78a854f161de969db7fd70e6efc87618551d3cdd/src/main/java/net/levelz/mixin/misc/EnchantmentScreenMixin.java#L40 This got fixed in a later version

nc5432 commented 2 years ago

I can confirm that this happens no matter what item you put in

Globox1997 commented 2 years ago

This should be fixed with the latest update

Veluz22 commented 1 month ago

I can confirm that it is still happening