Globox1997 / LevelZ

https://modrinth.com/mod/levelz
https://www.curseforge.com/minecraft/mc-mods/levelz
GNU General Public License v3.0
51 stars 50 forks source link

Easy magic incompatibility (seems fixable) #215

Closed Bob74 closed 1 year ago

Bob74 commented 2 years ago

Easy Magic also uses EnchantmentTableBlockMixin on onUse method:
https://github.com/Fuzss/easymagic/blob/1.19/Common/src/main/java/fuzs/easymagic/mixin/EnchantmentTableBlockMixin.java

When interacting with the enchantment table, it will work even without any skill points (the item still show that it requires skill points on the tooltip).

I don't know if it is a good solution, but I noticed that it works well if I set the injection point reference from INVOKE to HEAD in your code: https://github.com/Globox1997/LevelZ/blob/1.19/src/main/java/net/levelz/mixin/block/EnchantingTableBlockMixin.java#L26

Globox1997 commented 1 year ago

Fixed with https://github.com/Globox1997/LevelZ/commit/94567c45c79b8e7fb8cbec0dcd47fe94609c687e