search

Globox1997 / MedievalWeapons

https://modrinth.com/mod/medievalweapons
https://www.curseforge.com/minecraft/mc-mods/medievalweapons
MIT License
9 stars 12 forks source link

additional additions support #30

Closed Lukebb04 closed 1 year ago

Lukebb04 commented 3 years ago

add support for the additional additions mod

Globox1997 commented 3 years ago

Does this mod add weapons from the materials it is adding?

Lukebb04 commented 3 years ago

yes

chrsrns commented 2 years ago

Bumping this. I'm trying to add the support on a temporary fork. But so far, I only have the Rose Gold model assets done.

About the models for the additional additions support, I'd like to know how the assets in src/main/resources/assets/medievalweapons/textures/entity are generated?

Globox1997 commented 2 years ago

Since the visual bigger models are entities these assets are for the models here: https://github.com/Globox1997/MedievalWeapons/tree/1.18/src/main/java/net/medievalweapons/entity/model

chrsrns commented 2 years ago

What is your flow for creating the assets from src/main/resources/assets/medievalweapons/textures/entity? My current flow is taking the existing ones as templates and recoloring them, which is what I did for these assets.

I've already added some entries in the following files:

Is that all that I should change when adding new items? Other than creating new entity models to src/main/resources/assets/medievalweapons/textures/entity, I'm guessing I also need to add recipes, which I'll try to figure out later how to.

I noticed that Blockbench was used at some point, based on Line 2 from this file. Do you still have the project files somewhere? It'll make it easier to make the new assets on src/main/resources/assets/medievalweapons/textures/entity.

Globox1997 commented 2 years ago

That is what I basically do :D yea I should have them anyhwere, contact me on discord, Globox_Z #1024

chrsrns commented 2 years ago

Alright. I sent a friend request.

On Tue, Dec 7, 2021 at 12:23 AM Globox_Z @.***> wrote:

That is what I basically do :D yea I should have them anyhwere, contact me on discord, Globox_Z #1024

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Globox1997/MedievalWeapons/issues/30#issuecomment-986934264, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKKWNJDFKFNUD3IO6GKPB2DUPTPQ5ANCNFSM5CJRUD7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

RatDonkeyGoat commented 1 year ago

they changed the way rose gold works in additional additions here is the compat file with the new recipies

RatDonkeyGoat commented 1 year ago

CompatRecipes.java.zip CompatRecipes.class.zip medievalweapons-1.4.2.jar With Additional Additions corrected recipe.zip

Globox1997 commented 1 year ago

Updated additional additions compat with https://github.com/Globox1997/MedievalWeapons/commit/567db46c88827bfa8f0286eeddc116799e1e9ba4 Thank you @RatDonkeyGoat