search

Globox1997 / RpgZ

https://modrinth.com/mod/rpgz
https://www.curseforge.com/minecraft/mc-mods/rpgz
GNU General Public License v3.0
2 stars 4 forks source link

@Override causes conflict with villager_see_villager_do #42

Closed supersaiyansubtlety closed 10 months ago

supersaiyansubtlety commented 10 months ago

Minecraft Version

1.20.x

Mod Loader Version

0.15.6

Mod Version

0.6.0

Describe the Issue

rpgz's @Override of MobEntity.tickMovement ends up overwriting the method which makes any other mixins into that method fail villager_see_villager_do mixins to it here

You could replace your @Override with an @Inject with cancellable = true and it would be much more compatible

See user-created issue on my repo

latest.log

latest.log

Do you use any other mods except the required ones?

villager_see_villager_do

supersaiyansubtlety commented 10 months ago

Also I believe the super.tickMovement call in your current mixin is calling LivingEntity.tickMovement and not MobEntity.tickMovement which was probably the intent.

The inject I described would solve this in addition to being more compatible.

supersaiyansubtlety commented 10 months ago

working on a PR