Command feedback sent as a speech bubble

[SecretlyJealous]

Minecraft Version

1.20.x

Mod Loader Version

0.14.21

Mod Version

1.0.7

Describe the Issue

When I run a command on a server such as /plot info for example or /near the feedback I'm given in chat is also sent as a speech bubble above a random player near me:

latest.log

https://pastebin.com/Ra3vGfKP

Do you use any other mods except the required ones?

No response

[belcar-s]

This is because of my pull request, which interprets the first valid username in a message as being its sender. I’m not sure what the best way to solve this is. Maybe there should be a toggle between the old and new behavior, but ideally the mod wouldn’t rely on the message format alone. I think servers send information about which players send what messages. They might also tell the client whether a message comes from a player or not. Sadly, I don’t know how that works.

[SecretlyJealous]

This is because of my pull request, which interprets the first valid username in a message as being its sender. I’m not sure what the best way to solve this is. Maybe there should be a toggle between the old and new behavior, but ideally the mod wouldn’t rely on the message format alone. I think servers send information about which players send what messages. They might also tell the client whether a message comes from a player or not. Sadly, I don’t know how that works.

Your pull request is good though because before I was not able to see any speech bubbles on this server, now it works this bug is just a minor issue and would be nice if there was a way to fix it in the pr

[Globox1997]

@SecretlyJealous can you test this for me? talkbubbles-1.0.8.zip

[SecretlyJealous]

@SecretlyJealous can you test this for me? talkbubbles-1.0.8.zip

It still has the same issue, when I run a command the feedback shows as a bubble above the player near me

[Globox1997]

add me on discord Globox_Z