search

Globox1997 / VillagerQuests

https://modrinth.com/mod/villagerquests
https://www.curseforge.com/minecraft/mc-mods/villagerquests
MIT License
3 stars 7 forks source link

using datapack entry results in no quest. #2

Closed Monster-Zer0 closed 1 year ago

Monster-Zer0 commented 2 years ago

I could be doing something wrong here.. but even using the example json.. modifying it.. or changing it in any way I can (like the id number.. etc) yields no new quest for the toolsmith.

my folder layout is

data > villagerquests > quests > test_quest.json

im no newb at datapacks.. but also.. you know how working with code works.. sometimes you miss something.

thanks for the help.

Globox1997 commented 2 years ago

Probably some small bug which I fixed - if you have less quests in your pack there is a high chance that the vill doesn't get any quests for the player Waiting for #1 for approval until I publish a new version

Monster-Zer0 commented 2 years ago

so you are saying that just because a quest is made in the datapack.. it's not a guarantee that a villager will have it. there is a chance?

Monster-Zer0 commented 2 years ago

figured out the issue. appears it was a combo of not having a high enough level in your mod.. levelz.. and chance.

Monster-Zer0 commented 2 years ago

actually upon further testing. quests show up when you spawn a villager in and have then take their profession.

however.. if a villager spawns from a modded structure.. like a village, then either takes on a profession or you can give them one.. and the quest will not show up.

in my testing. this is with a repurposed structure village.

Globox1997 commented 2 years ago

I will look into it

frikinjay commented 2 years ago

The datapack doesnt seem to work?

Monster-Zer0 commented 2 years ago

It works. You just have to spawn in a villager. You can't use one that naturally spawns in.

Globox1997 commented 2 years ago

Released a new version, probably fixes the issue

Monster-Zer0 commented 2 years ago

same issue, unfortunately.

frikinjay commented 2 years ago

I see the quests now but the icons are messed up and render way off from where theyre supposed to

frikinjay commented 2 years ago

And seems like /quest remove remove or /quest remove removeAll dont seem to do anything. I still cant see the quest i denied.

wolfkidsounds commented 2 years ago

actually upon further testing. quests show up when you spawn a villager in and have then take their profession.

however.. if a villager spawns from a modded structure.. like a village, then either takes on a profession or you can give them one.. and the quest will not show up.

in my testing. this is with a repurposed structure village.

I'm having the same issue right now. However, would test further and report back.

When this type of villager (in my case armorer) is leveling up, everything behaves as normal. - However the initial quests (level 0) will not show up on villagers that where already spawned in before.

Globox1997 commented 2 years ago

Quests which are finished by the player won't show up anymore (if no timer or timer is on going) on all villagers which have the same quest

alecs420 commented 2 years ago

can you send me your datapack because i cant get mine to work and id need one working to learn from it

Globox1997 commented 1 year ago

Will close this issue by directing to my discord which can be found on the curseforge website. If you have questions for how to create a datapack, pls ask there :)