search

Globox1997 / tiered

https://modrinth.com/mod/tieredz
https://www.curseforge.com/minecraft/mc-mods/tieredz
MIT License
1 stars 15 forks source link

Incompatibility with BCLib, Reforged button on anvil doesn't work #11

Closed ConqAra closed 1 year ago

ConqAra commented 2 years ago

I'm trying to click on the reforge button in the anvil menu and it just doesn't work.

ConqAra commented 2 years ago

May have to do something with a mod incompatibility? I can send my log but i dont see an error for this.

Log: https://paste.ee/p/3InhH

Globox1997 commented 2 years ago

Mh this is pretty bad, the good thing is you only have quadrillion mods installed xD I have no idea what could cause this issue, maybe a screen editing mod

Leonelecg commented 2 years ago

I have the same problem, and I found out why, I guess it's an incompatibility with BCLib

Here is the BCLib curseforge link: https://www.curseforge.com/minecraft/mc-mods/bclib

jklw10 commented 2 years ago

Can confirm, button doesn't work and I do have BCLib but I cannot know if that's the one mod that causes this. I'm unsure because i don't know if bclib itself changes the anvil menu in any way?

Globox1997 commented 2 years ago

If you guys can narrow down the incompatibility, that would be super helpful :) I will look into it when I have time for modding again

Leonelecg commented 2 years ago

I'm pretty sure BCLib is what's causing the error, maybe some kind of incompatibility

jklw10 commented 2 years ago

I think a good temporary fix would be to add a keybind to switch to reforge screen...

Globox1997 commented 2 years ago

Pretty sure this is the issue: https://github.com/paulevsGitch/BCLib/blob/main/src/main/java/ru/bclib/mixin/common/AnvilMenuMixin.java#L180 BCLib overrides the onclick method (different mappings) so the tiered injection won't get used Can't make it compatible from my side, except adding a keybind which sucks

jklw10 commented 2 years ago

hmm i assume you'll open an issue for it then. or just make a pull request with it being an injection instead of override.

Globox1997 commented 2 years ago

I assume you will open an issue :)

itsdinkd commented 2 years ago

You guys are lazy! I'll open the issue.

itsdinkd commented 2 years ago

I assume you will open an issue :)

Please respond to the developer in the ticket I opened on their github. It's linked here

kleonaut commented 2 years ago

Please address this

Any plans of applying these fixes to 1.18.2?

Yes, but there is no ETA as it currently has low priority. As far as I can tell, TieredZ can just change the mixing priority to override ours. Which should be absolutely fine. Our mixing is there to show UI in case there are multiple recipes for the same list of ingredients. I think that is not uses in 1.18.2 anyway.