search

Globox1997 / tiered

https://modrinth.com/mod/tieredz
https://www.curseforge.com/minecraft/mc-mods/tieredz
MIT License
1 stars 15 forks source link

Armor re-calculates? #24

Closed Mudkipstalker closed 1 year ago

Mudkipstalker commented 1 year ago

Sooo the title says it all. Getting hit makes the armor bar seem to recalculate the armor and toughness and all the other effects of the prefixes

Globox1997 commented 1 year ago

Should be fixed with the latest commits

Mudkipstalker commented 1 year ago

Should be fixed with the latest commits

Ah thank you, built the latest commit and it works. Keep up the hard and good work!

Mudkipstalker commented 1 year ago

Sooo bad idea trying it on a server LOL, i'll just wait for an Official update but it seems to be going along nice. And the tooltips seem to not follow enchant updates either lol and this on the non-host end (just in-case it helps, posting this picture) image

Globox1997 commented 1 year ago

What exactly are the issues?

Mudkipstalker commented 1 year ago

What exactly are the issues?

So the issue was, the armor recalculates when hit by anything and in the latest commit (like you said), yes it seemed to have fixed that, however, it caused other issues as you can see in the image above when non-host tries to join.

One other issue i can note about atm is that the Reforges/prefixes mess up enchants modifying the tooltip. (They still apply to the weapon but the tooltip doesn't reflect it when reforged and/or breaks it entirely

This should be 24 (+15% Damage) image

Here's a normal Netherite Sword as a test image image image

It seems if something modifys a stat on whatever is reforged that already has the stat (in this case a sword, modded or not) it stops visibly showing that the enchants are applied to the weapon but the enchants still function as normal.

image (Just figured this out) It even applies to attack speed but this time nothing is modifying it but the reforge, however it still attacks with -25% instead of the so called -2.4 attack speed, so it seems the issue isn't just in the enchants visually, the reforges visually update the tooltip wrong anyways (IF it adds or subtracts to a stat that's already there.)

These are the issues i've found so far

Globox1997 commented 1 year ago

fixed it with https://github.com/Globox1997/tiered/commit/154e512e533cf81906bb98075717a020b8776a8d