Globox1997 / tiered

https://modrinth.com/mod/tieredz
https://www.curseforge.com/minecraft/mc-mods/tieredz
MIT License
1 stars 15 forks source link

Innate tooltips disappear in some cases #52

Closed halflumi closed 1 year ago

halflumi commented 1 year ago

Using 1.2.4, looks like the original tooltips of an item sometimes disappear (see examples and screenshots below). It would probably make the tooltips more consistent by displaying either the innate stats and modifiers separately (like in Example 3) or the accumulated final results.

Example 1, an Iron Helmet of tiered:uncommon_armor_2 displays "-1 Armor" when in fact, it provides 1 armor because the helmet provides 2 armor by itself:

image

Example 2, a Diamond Helmet of tiered:common_armor_4 only shows armor attributes. The "+2 Armor Toughness" disappears even though the tiered attributes don't change armor toughness:

image

Example 3, a Diamond Helmet of tiered:uncommon_armor_4 displays both the innate armor stat and tiered modifier, though the armor toughness is still missing:

image

Globox1997 commented 1 year ago

This is probably a mod incompatibility or does this happen with only tiered + deps installed

halflumi commented 1 year ago

Well, it didn't occur to me that this would be an incompatibility issue. This doesn't happen with only Tiered installed (screenshot below). It looks like the issue is caused by PlayerEx, which probably falls out of the scope of tiered. Thanks for your prompt response!

P.S. During testing with only Tiered installed, the modifier that decreases durability doesn't seem to work. I'll open a new thread for that.

image