help node was catching the hide/show events intended for the subfield

Glodenox / twitch-chat-monitor

Twitch Chat Monitor that allows the chat to be shown comfortably on a big monitor. Useful for room-scale streaming where the chat needs to be readable from a distance.

40 stars 11 forks source link

help node was catching the hide/show events intended for the subfield #52

Closed frnknstn closed 1 week ago

frnknstn commented 1 week ago

The "image height" suboption for the "show images" option wasn't showing when "show images" was enabled. I reordered the help node to be in the suboption div, like it is elsewhere.

Glodenox commented 1 week ago

Hey, thanks for the pull request! I've investigated the issue and while you were absolutely right about that subfield remaining hidden, the cause wasn't anything in the HTML, but a missing .nextElementSibling in the JavaScript logic.