Enable from Layer menu does not work as intended

Glodenox / wme-om

Waze Map Editor - Open Maps userscript

GNU General Public License v2.0

8 stars 7 forks source link

Enable from Layer menu does not work as intended #80

Closed Hipska closed 3 years ago

Hipska commented 4 years ago

I think it's easier to explain with images.

Initial state after loading page:

After enabling:

After disabling:

Also note the different size of the checkbox and the OpenMaps layer group icon is not working.

Chrome 81 MacOS

Glodenox commented 4 years ago

The different sizes of checkboxes is something Waze can fix. I've created a bug report for that and that is somewhere in their development queue.

As for the other issue: I'll look into it. The way the new checkbox created by Waze works is still a bit of a mystery to me at the moment.

Hipska commented 4 years ago

So you have the same behaviour and it looks the same?

Glodenox commented 4 years ago

For me it works fine, but Paul also mentioned this issue when he has Fix UI reset the menu and sidebar. I did have to negate the "checked" state for it to work, which I found weird, so I'm pretty certain I'm doing something iffy there.

Hipska commented 4 years ago

If it might help, I don't have the FixUI plugin.

Hipska commented 3 years ago

Issue doesn't seem to occur anymore. Fixed?

Glodenox commented 3 years ago

The checkboxes thing was fixed, but I haven't changed anything in the logic for group toggling yet. I was actually just working on a rewrite of that part of the script.

Hipska commented 3 years ago

Group toggle icon also works..