search

Glosseta / glosseta

Glosseta is an open-source glossary meant to help people explore and learn the terminology behind web3
https://www.glosseta.com
MIT License
24 stars 7 forks source link

Add word of the day section #158

Closed alireza-jahandoost closed 2 years ago

alireza-jahandoost commented 2 years ago

What does this PR do?

Add "Word of the day" section to index page

Any helpful background information around the changes?

Any new dependencies? Why were they added?

No

Relevant Screenshots/gifs

Does is close any issue(s)?

issue #157

Closes # ...

vercel[bot] commented 2 years ago

@alireza-jahandoost is attempting to deploy a commit to the Glosseta Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/glosseta/glosseta/7aNaZDi9X7G4StJEerx2HjgMvz3y
✅ Preview: https://glosseta-git-fork-alireza-jahandoost-add-word-o-a3a179-glosseta.vercel.app

narbs91 commented 2 years ago

Hi @alireza-jahandoost thank you so much for the prompt work on this issue! It looks like you are getting some build issues with the landing page. Yyou can observe the output here or look to reproduce it via yarn build on your machine. It's likely the compiler freaking out on some things it might not be guaranteed to be defined at build time

alireza-jahandoost commented 2 years ago

@narbs91 The problem solved with moving new component to src/components directory. I think we have to move other components from src/pages directory to this directory. Should I open an issue about it?

narbs91 commented 2 years ago

Hi @alireza-jahandoost moving it outside the pages folder seems kinda odd for it to be the fix. I'll have a closer look in the upcoming days as well as a review of the UI (from my original design proposal) and let you know. Thank you for the great work 🚀

alireza-jahandoost commented 2 years ago

Hi @narbs91 . If you reset the HEAD to the point that it has error, and try to build, a link to the cause of error is this. And the recommended way to solve it is to move every non-pages to out of page directory.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
glosseta ✅ Ready (Inspect) Visit Preview Apr 19, 2022 at 4:27AM (UTC)
narbs91 commented 2 years ago

@all-contributors please add @alireza-jahandoost for code

allcontributors[bot] commented 2 years ago

@narbs91

I've put up a pull request to add @alireza-jahandoost! :tada: