search

GlotPress / GlotPress

:earth_africa: :earth_americas: :earth_asia: GlotPress is a WordPress plugin to let you set up your own collaborative, web-based software translation tool.
https://wordpress.org/plugins/glotpress/
GNU General Public License v2.0
337 stars 120 forks source link

Fuzzy translations can be saved without edits #1248

Open ocean90 opened 3 years ago

ocean90 commented 3 years ago

Reported in https://meta.trac.wordpress.org/ticket/5788.

I'm working on nl_NL-formal waiting strings and with this fuzzy, I didn't click "Accept" but clicked "Save"... And the translation changed to me instead of the original translator... I didn't change a single thing about the string...

ocean90 commented 3 years ago

Maybe we can extend the check added in https://github.com/GlotPress/GlotPress-WP/commit/39e768afeba5c60d2f22c84ff413dd2cf129a31a to also include fuzzy strings.

https://github.com/GlotPress/GlotPress-WP/blob/0c395a7a8f37ab3b5ebafd2b239c74392e5177f9/gp-includes/routes/translation.php#L296-L310

NekoJonez commented 3 years ago

Thx for reporting it upstream... I personally find it tricky when it needs to reported here instead of the meta trac...

(And it would be so awesome if a fix happens here, the meta trac ticket would be updated in a way but that is a whole other proces :P)

psmits1567 commented 3 years ago

This is probably caused by the fact that you are PTE. Normally you cannot save a translation twice, and change the name of the original. Or there has been a minor change in the original, and the old translated text is copied. So there is basically a new translation

NekoJonez commented 3 years ago

This is probably caused by the fact that you are PTE. Normally you cannot save a translation twice, and change the name of the original. Or there has been a minor change in the original, and the old translated text is copied. So there is basically a new translation

Yeah, before I was PTE , I was able to fix fuzzy's by them ending up as new ones.