GlotPress / gp-translation-helpers

GlotPress plugin to add features like discussions
https://glotpress.blog
4 stars 4 forks source link

Make a submitted feedback immediately visible #120

Open amieiro opened 1 year ago

amieiro commented 1 year ago

What problem does this address?

This was proposed by @La-Geek here.

Why do you see a submitted feedback only after cumbersome 2 more clicks (1st hamburger icon, 2nd discussion) and not immediately at the translation (a hint with a descriptive link would do it)? A given feedback makes only sense, if you see, that it exists.

What is your proposed solution?

We have talked about to add the 3 tabs you can get in the discussion page (and another one for the current info) and maybe the translation memory

image

in this location, so we can have there important information.

image

Something like you can see in the wordpress.com translation system.

image

La-Geek commented 1 year ago

What I think would be a good UX for all (new and experienced) translators:

  1. Given feedback should be visible at a glance
  2. It should be highlighted to obtain the attention
  3. The hint text should be different from the "comment" hint above the translation string
  4. One date -> the date of the last feedback/comment/reply in discussion should be displayed

Kinda like on the attached screenshot.

Reason:

  1. Many translators don't even know about the feedback tool, they don't read in Slack, make.wordpress.org or the WordPress news either. Without clear and understandable marking, they may never know it.
  2. see 1.
  3. There is a comment area above the string to be translated. Without a clear distinction from the feedback, you might assign the new hint to these comments.
  4. You should somehow be able to see if you have already read this comment, hence the date.

visible_given_feedback

akirk commented 1 year ago

@La-Geek, you said "Given feedback should be visible at a glance" which would be possible with what @amieiro proposed that the "Comments" tab would have an indicator that has the number of comments, no?

We'll investigate how easy it is to display the tabs on the side, we actually designed the plugin to be capable of this but haven't tried it in a while.

La-Geek commented 1 year ago

@akirk I'm afraid that won't be enough. It does not obtain the attention and it does not include a date. I listed (my) reasons above :)

Zodiac1978 commented 1 year ago

I thought about why I would read a discussion/feedback in the first place, and I imagined two use cases:

For 1 I just want to know that there are comments (they must not be recent). For example, there could be an explanation why the typography in curly quotes is different for German (compared to the original string).

For 2 I am afraid nobody will revisit all the translations they made and check if there are comments. I haven't followed the development in the last time very closely, but if those translators get a notification, I think this will be a better way than checking every single translation.

La-Geek commented 1 year ago

As far as I know you must subscribe, if you want receive a notification (this is unknown, I guess). Imagine the situation of PTEs or GTEs if they subscribe to every translation. I don't want get daily a bunch of emails.

The recent situation for translators is. If strings are rejected, they get no notification. If a translator is interested, why a translation has not been approved, translator could filter (I guess this is also mostly unknown).

Strings with feedbacks get the status "Changes requested" (but finding them at a glance is not given either, see #135). And if someone has no idea, what the feedback tool does, will this translator ever subscribe or find the feedback/discussion?

As translator, if you look for it, you see rejected (also an option with a submitted feedback) strings and normally, if you are interested "why" this translation was not approved, you'll click on it.

Next is, that other translators don't see, if a feedback exist and maybe they make the same mistake in translation. Recent we have the situation, that translators can suggest translations for the same string. Also here, it would be great to see, that (and which) feedbacks yet exist and also the date of the newest feedback is helpful.

Brief summary:

In my opinion PTEs and GTEs won't subscribe. After some time they may know, the state "Changes Requested" but they can't see, if they have yet read it (recent date of feedback

New translators don't know it. Other translators don't see yet given feedback

Supplement

And it's never wrong to make functions accessible in different ways and as easily as possible. One should not exclude the other.