search

Glow-Lang / glow

The Glow language for Blockchain Decentralized Applications.
https://glow-lang.org
Apache License 2.0
58 stars 8 forks source link

Update Glow Cardano for PAB - [merged] #382

Closed kwannoel closed 3 years ago

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 01:39

Merges kwannoel/glow-cardano-contract -> master

Port over glow-cardano contract from: https://gitlab.com/mukn/glow-cardano-pab/-/merge_requests/1

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 02:17

added 1 commit

Compare with previous version

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 02:17

changed title from {-Kwannoel/g-}low {-c-}ardano {-contract-} to {+Update G+}low {+C+}ardano {+for PAB+}

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 02:17

changed the description

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 02:18

Commented on cardano/haskell/.devcontainer/devcontainer.json line 1

Skip

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 02:19

added 1 commit

Compare with previous version

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 02:20

resolved all threads

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 02:22

Commented on cardano/haskell/lib/Glow/Contract.hs line 45

NOTE: Style changes are due to the use of ormolu for formatting.

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 02:29

requested review from @isd

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 02:29

resolved all threads

kwannoel commented 3 years ago

In GitLab by @isd on Sep 8, 2021, 09:36

Commented on cardano/haskell/lib/Glow/Client.hs line 126

Why is the show datum commented out here? (and similar elsewhere)

kwannoel commented 3 years ago

In GitLab by @isd on Sep 8, 2021, 09:36

Commented on cardano/haskell/lib/Glow/CodeGen.hs line 3

I assume you meant relies here.

kwannoel commented 3 years ago

In GitLab by @isd on Sep 8, 2021, 09:36

Commented on cardano/haskell/lib/Glow/Contract.hs line 53

It took me a second to figure out, but if I'm reading this correctly, you mean once cardano/plutus implements some similar functionality we should use that instead? I'm not sure I would have gotten that without being around other discussions about this not existing. I think spelling out that you mean implemented in/by plutus would make this clearer.

...unless I've entirely misinterpreted, in which case it should be clarified in some other way :)

kwannoel commented 3 years ago

In GitLab by @isd on Sep 8, 2021, 09:36

Commented on cardano/haskell/lib/Glow/Contract.hs line 279

Can you explain why this pragma needed to be added?

kwannoel commented 3 years ago

In GitLab by @isd on Sep 8, 2021, 09:36

Commented on cardano/haskell/lib/Glow/Parser.hs line 196

The trouble here is that conceptually there should be separate types for participant statements vs. consensus statements. e.g. in runtime/consensus-code-generator.ss, if the compiler sees a participant:withdraw, it will just throw an error. So not all statements are valid for all targets. But the fact that it's in an untyped language means this is less explicit.

I don't think it is worth it right now to define two separate types; let's get a first pass of this merged and then we can talk cleanup. But I think probably what you have written is "right" in the sense that these really do have the same semantics, they just aren't the same type...

kwannoel commented 3 years ago

In GitLab by @isd on Sep 8, 2021, 09:36

Commented on cardano/haskell/test/assets/current_project.sexp line 1

Maybe rather than having this duplicated between here and the literal in Samples.hs, we could use something like the heredoc package's there quasiquoter?

https://hackage.haskell.org/package/heredoc-0.2.0.0/docs/Text-Heredoc.html

(Then again, it feels like such a small thing to pull in a dependency for...)

kwannoel commented 3 years ago

In GitLab by @isd on Sep 8, 2021, 09:36

Commented on cardano/haskell/README.md line 171

It seems like this example could be cut down substantially by just in-lining these definitions into the record above; it's not clear to me what factoring them out is buying you, and especially since this is supposed to be a repl session, we should probably keep this concise. This would obviate many of the imports as well.

kwannoel commented 3 years ago

In GitLab by @isd on Sep 8, 2021, 09:36

Mostly this looks good, some comments in-line.

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 09:44

Commented on cardano/haskell/lib/Glow/Parser.hs line 196

Will include this in a comment.

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 09:45

Commented on cardano/haskell/test/assets/current_project.sexp line 1

I'll remove these. Currently not used in testsuite.

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 10:37

Commented on cardano/haskell/lib/Glow/Client.hs line 126

Removed it for demo purposes, to cleanup the output (currently includes the dump of the entire contract). Re-including it.

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 11:33

Commented on cardano/haskell/lib/Glow/Client.hs line 126

changed this line in version 4 of the diff

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 11:33

Commented on cardano/haskell/lib/Glow/CodeGen.hs line 3

changed this line in version 4 of the diff

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 11:33

Commented on cardano/haskell/lib/Glow/Contract.hs line 53

changed this line in version 4 of the diff

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 11:33

Commented on cardano/haskell/lib/Glow/Parser.hs line 196

changed this line in version 4 of the diff

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 11:33

Commented on cardano/haskell/test/assets/current_project.sexp line 1

changed this line in version 4 of the diff

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 11:33

Commented on cardano/haskell/README.md line 171

changed this line in version 4 of the diff

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 11:33

added 1 commit

Compare with previous version

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 14:13

added 90 commits

Compare with previous version

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 22:26

Commented on cardano/haskell/lib/Glow/CodeGen.hs line 3

Updated. Thanks.

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 22:26

Commented on cardano/haskell/lib/Glow/Contract.hs line 279

Added comments on this.

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 8, 2021, 22:27

Commented on cardano/haskell/README.md line 171

Cleaned up the README.

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 9, 2021, 22:08

resolved all threads

kwannoel commented 3 years ago

In GitLab by @isd on Sep 10, 2021, 02:53

approved this merge request

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 10, 2021, 03:33

added 6 commits

Compare with previous version

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 10, 2021, 03:35

Rebased^.

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 10, 2021, 03:35

enabled an automatic merge when the pipeline for 4b01e559fa6eef30c71cff6cc4f5fa952b7a3eea succeeds

kwannoel commented 3 years ago

In GitLab by @kwanzknoel on Sep 10, 2021, 03:47

mentioned in commit dfb1311e2f762f9310e647b0d5b86cb251f37419