GlowPuff / ImperialCommander2

A companion app for the Imperial Assault board game.
MIT License
87 stars 12 forks source link

Adding tiles translations and icons to the Info Popup #101

Closed ilujito2 closed 2 months ago

ilujito2 commented 2 months ago

This is a follow-up of https://github.com/GlowPuff/ImperialCommander2/pull/85 as it appears that I had missed 1 scenario (reported here: https://github.com/GlowPuff/ImperialCommander2/pull/85#issuecomment-2210325514).

jph33 commented 1 month ago

@ilujito2 Thanks for the evolution. Don't you think that the screen seems empty now? Perhaps a larger font size should be better? image

ilujito2 commented 1 month ago

@jph33 Hi ! Changing this may actually impact other languages. Furthermore, as this is not just 1 string being outputted but several unity components added one after the other, this would rather be a change on the unity side and I may not be the best suited person for this type of change. Finally, looking at the previous version (with Core 7 ...), it's actually not that far from the current output. In conclusion, I think that we should probably keep it that way for now ; it's not perfect, but it looks nonetheless acceptable. Cheers, ilu

GlowPuff commented 1 month ago

Hello, I just pushed this change - slightly larger font/icon size and color coding for the icon, tile number, and tile count: image

ilujito2 commented 1 month ago

Thanks a lot @GlowPuff