Closed ilujito2 closed 3 months ago
Hey there!
I'd rather not do that, but instead of simply rejecting the pull request, I'd like to offer some insight - there's more going on behind the scenes here.
I faced that problem when converting the missions to the new campaign management. The trouble is that it's not only 4 missions. There are only a few missions in "Jabba's Realm", true, but the entire "Heart of the Empire" and extended "Tyrants of Lothal" campaigns are dependent on the Rebels selecting story missions. Removing all of those would render the campaign management features in a big selection of missions moot, and there's one more problem: If people forget they are able to choose missions, like you did, they need to dig out their printed campaign guide to see what missions they are able to select. If I fill in a default mission, at least they can keep going with the default mission without referring to the campaign guide, even if they forgot the missions.
Of course, that's still far from ideal. It's only a workaround. There are two "ideal" solutions. One, implement a feature that allows a mission designer to set a "mission list" instead of a single mission as the next mission. But this would require reworking both ICE and IC2 and is probably a lot of work. Two, make the players choose immediately, right at the end of the mission that gives them the choice, by asking them what mission they want to play next, and then setting that mission. This is the way I did it for "Tyrants of Lothal", if I remember correctly. I considered doing it for the other campaigns, too, but that would have meant coordinating a huge translation effort in addition to everything else going on in the update (I can only handle English and German, after all). Since the update was already way bigger than originally imagined, I shelved it and decided to go with the workaround for now.
I still hope to revisit it at some point and implement the mission selection questions. But until I (or somebody else) gets around to it, I'd just keep the workaround.
Thanks a lot for this insight! It looks to be indeed more complex than I initially thought. Thanks again for these details and then please feel free to close this request without merging it.
Hi, Please reject/close this PR if you think it's not appropriate.
In short: I played a Jabba campaign and we got sidetracked by the fact that a story mission was automatically filled. Indeed, we forgot that we actually had the choice between 2 Story missions because of the mission automatically filled.
I feel that when players have the choice between multiple story missions, the app shouldn't automatically select one.
Of course, I let you (@GlowPuff) and @Noldorion decide if this idea is appropriate or not. In case not, of course, please reject/close this PR. In case it is, this PR is removing automatic mission selection for the few missions (4) ending up asking players to places multiple Story missions in play.
Cheers, ilu