GlowPuff / ImperialCommander2

A companion app for the Imperial Assault board game.
MIT License
88 stars 12 forks source link

Mission Log untranslated strings #45

Closed jph33 closed 1 year ago

jph33 commented 1 year ago

Hi, I found some untranslated fields in the mission log: PrtScr capture_90 The deployment Event name and the Continue button are not translated.

GlowPuff commented 1 year ago

Thank you! I also noticed ROUND wasn't using the translations. All fixed now.

jph33 commented 1 year ago

@GlowPuff btw i tried to Build an Android apk with your last deliveries but i am facing an error when trying to launch a mission or seeing the tiles. Here is a screenshot. Any advice or perhaps it is normal ? For windows Build it works. Screenshot_2023-05-25-19-45-24-361_com.GlowPuff.ImperialCommander2.jpg

GlowPuff commented 1 year ago

Did you rebuild the Addressable Assets first? After you change the build target, the Assets need to be rebuilt for that platform before building the actual app. I haven't tested on Android yet, so this could be another issue entirely, but start with rebuilding the Assets.

In the Addressable Asset window (Window->Asset Management->Addressables->Groups), select Build->Update a Previous Build asset

jph33 commented 1 year ago

Thanks @GlowPuff this was the pb. Thank you. A last question do add some parameters to make all apks compatible each others (recogniztion of the param save files, save games...)? For me each time a build an apk i have to redefine all my options and save files.

GlowPuff commented 1 year ago

That's interesting... When I install a new version of the app for testing, Android always asks me to "upgrade" the existing app. And it keeps all the settings and saved files intact. The app uses the same identifier (com.glowpuff.ImperialCommander2). That alone, I believe, should make it "upgrade" existing installations without losing data. I'm not sure what else to do about this.

jph33 commented 1 year ago

Thanks For the answer. In fact i understood. I used to uninstall first then install the New version. On my tablet it keeps my settings and saves whereas on my cell phone everything is erased. So by now i will just install the New version without uninstalling the previous. Thanks again