GlowPuff / ImperialCommander2

A companion app for the Imperial Assault board game.
MIT License
87 stars 12 forks source link

Adding translation for the Medpac tooltip. #69

Closed ilujito2 closed 3 months ago

ilujito2 commented 3 months ago

Hi GlowPuff,

I hope you're doing well. First, I saw that you just added the latest French translations to IC2 : thanks a lot for that! (I'm still working on translating all the rest)

I wasn't really sure on how to proceed in order to propose a code change. I didn't really know if there was a process I should have followed, or a communication channel I should have contacted you through before. Please don't feel offended by me directly proposing a code change. Of course, feel free to directly reject this PR if I did not proceed the ways I should have.

I'm proposing this change in order to add translation for the Medpac tooltip. I did a private build to test it and confirm that it was working for En and Fr, but also for other languages that are defaulting to En (as it is now).

It will also need a small code change to the Translator app (to include this new translation), but if you accept this change, I can do a PR for the Translator app code as well.

Thanks a lot in advance! ilu