search

GlowstoneMC / 1.13-board

Issue board for 1.13 tasks for Glowstone.
MIT License
2 stars 0 forks source link

Fix tests [$100] #29

Open mastercoms opened 5 years ago

mastercoms commented 5 years ago

This issue is part of the 1.13.x compatibility Epic.

All contributions are subject to the Glowstone CLA. In short, contributions must not contain any content (code or otherwise) copied from, inspired by or based upon content from Mojang or third-party projects that are based on such content (CraftBukkit, Spigot, Forge, ...).

Description:

Most of our tests were made with pre-1.13 IDs and structures in mind. We need to update tests after implementing all other features, to make them use 1.13 features and interfaces that we create when adding 1.13 support.

Relevant Code:

https://github.com/GlowstoneMC/Glowstone/tree/1.13/src/test

--- There is a **[$100 open bounty](https://www.bountysource.com/issues/80734436-fix-tests?utm_campaign=plugin&utm_content=tracker%2F144870401&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F144870401&utm_medium=issues&utm_source=github).
SsorWayfinder commented 4 years ago

I can take this on if no one else has shown interest.

mastercoms commented 4 years ago

Sure! But please talk with us on Discord to make sure we have good tests that don't conflict with what we have in mind for the implementation.

SsorWayfinder commented 4 years ago

Based on our conversations on the discord, the desired end result is to make the set up and action tested to be done in the 1.13 way.

The results of interacting with the source in a 1.13 way should pass, even if it's not the behavior we'll eventually want.