TrappedChest's MaterialData should be org.bukkit.material.Chest

GlowstoneMC / Glowkit-Legacy

A continuation of Bukkit for use with Glowstone

GNU General Public License v3.0

27 stars 12 forks source link

TrappedChest's MaterialData should be org.bukkit.material.Chest #23

Closed Tonodus closed 9 years ago

Tonodus commented 10 years ago

It's confusing that TrappedChests don't have org.material.Chest as MaterialData. That is IMO a logical mistake and TrappedChests' facing direction can't be changed (by plugins).

This PR changes this without breaking any plugins/sever implementations/etc.

Edited by turt2live

Related links:

Glowstone: GlowstoneMC/Glowstone#358
- Glowstone PR is not required for operation/implementation

turt2live commented 10 years ago

Closing as this is no longer linked to an applicable Glowstone PR. Please respond back if this is still required (it doesn't look like it).

Tonodus commented 9 years ago

@turt2live Since https://github.com/GlowstoneMC/Glowstone/pull/358 has come alive, this should be re-opened. When this PR is pulled, the double chests implemented in the above PR should automatically connect right (only trap&trap or not trapped&not trapped).

Tonodus commented 9 years ago

@turt2live made it dynamically.

turt2live commented 9 years ago

I don't know why I closed this in the first place... it's Glowstone agnostic...

Tonodus commented 9 years ago

@turt2live applied your suggestions.

SpaceManiac commented 9 years ago

Merged in 4e9cc32cffc2d26c69ebe10e3ff728f07a77aef5.