search

GlowstoneMC / Glowkit-Legacy

A continuation of Bukkit for use with Glowstone
GNU General Public License v3.0
27 stars 12 forks source link

Fix facing methods for fence gates #26

Closed socram8888 closed 10 years ago

socram8888 commented 10 years ago

Fix for https://github.com/GlowstoneMC/Glowstone/pull/200#issuecomment-56320882

Tonodus commented 10 years ago

Why did you invert the given direction? That doesn't make that much sense and isn't expected IMO.

socram8888 commented 10 years ago

GATE_* were already defined and it's the direction the gate is open/opens to. So if the player is looking at the north BlockFace and interacts with that, the gate doors open to the south.

Tonodus commented 10 years ago

I think it's confusing since you'd expect it to set the direction MC use. So if you call that method the same facing direction should be visible when you hover over the gate in MC debug screen.

For fence gates implementation we can easily use getOppositeFace() if we need to do so.

SpaceManiac commented 10 years ago

I think I agree with Tonodus here. setFacing() and getFacing() should indicate which direction the fence gate is facing, which is the "outwards" direction, and ought to match what shows up in the F3 menu. The oppositeFace() can easily be done in Glowstone like it is for many other blocks.

SpaceManiac commented 10 years ago

Merged at long last, with the changes discussed above, in 54bf87837fafb0b48bac20e6de6dba455d96d10e.