search

GlowstoneMC / Glowstone-Legacy

An open-source server for the Bukkit Minecraft modding interface
Other
363 stars 121 forks source link

Fix the player 'joining' when they should be kicked #521

Open m3rcuriel opened 9 years ago

m3rcuriel commented 9 years ago

ORIGINALLY PR #518

This PR fixes issue #510, and #156, as well as touches on issues addressed in PR #373 about errors when not on a server whitelist.

The PR moves the method calls that send the join packet to the player from the constructor to a seperate method, and then calls that method once the player has been confirmed, and the PlayerLoginEvent has not been disallowed.

The creation of the InventoryMonitor is necessary in order to prevent errors with pulse.

Edited by turt2live

Related Links:

turt2live commented 9 years ago

This still displays a message that the player left the server. Does not fix #156 as claimed :(

dequis commented 9 years ago

Does this attempt to fix #296?

turt2live commented 9 years ago

@dequis yes, as per the description it includes similar changes to #373

m3rcuriel commented 9 years ago

No, it is not intended to fix #296. #373 included changes that fixed issue #156, which are included in this PR.

turt2live commented 9 years ago

Your PR description says it includes changes from #373 which is a direct fix for #296...

turt2live commented 9 years ago

@SpaceManiac This pull request is still pending pull. The pull request has been re-tested and is confirmed to be operational.