GlowstoneMC / Glowstone-Legacy

An open-source server for the Bukkit Minecraft modding interface
Other
363 stars 122 forks source link

Parse JSON when loading sign text NBT #557

Closed dequis closed 9 years ago

dequis commented 9 years ago

Fixes #528

Still uses plaintext internally, since we don't have a robust json chat parser yet. TextMessage.asPlaintext() is rather primitive too

Saving also uses plaintext for the sake of simplicity. Vanilla handles that correctly, since it's needed when migrating from 1.7 maps.

To test this:

Old behavior adds quotes around lines with content, and either null or "" for lines without.

New behavior should show no differences.

turt2live commented 9 years ago

@dequis or @SpaceManiac if you have a chance, please confirm if this is now not needed due to https://github.com/GlowstoneMC/Glowstone/commit/d07e99d4a2aa66878a7055cc5d21917b0df3808b

turt2live commented 9 years ago

<dx> this kills the PR