search

GlowstoneMC / Glowstone-Legacy

An open-source server for the Bukkit Minecraft modding interface
Other
363 stars 122 forks source link

[minor] Using port 0 should tell you the port in the log #571

Closed turt2live closed 9 years ago

turt2live commented 9 years ago

Fun fact: By using port 0 you bind to whatever port the OS decides to use (first available).

Glowstone should print the port in the log when it says it has bound correctly. Currently it doesn't do a very good job of that...

21:59:12 [INFO] Binding to address: 0.0.0.0/0.0.0.0:0...

turt2live commented 9 years ago

Also GlowServer#getPort() returns 0 when it should return the actual port.

turt2live commented 9 years ago

(complimentary ticket spam)

Fun fact of the day: Using port 0 in conjunction with some form of LilyPad support causes the LilyPad Connect server to be unable to connect to your instance because the Connect plugin sends getPort() as the server's port, thereby sending 0, thereby forcing the Connect server to attempt to redirect the client to "127.0.0.1:0", which is impossible.

@coelho might be interested to know that because of this failure, Connect still reports redirect success even though the player doesn't go anywhere and the Connect log has a nice error.