search

GlowstoneMC / Glowstone-Legacy

An open-source server for the Bukkit Minecraft modding interface
Other
363 stars 121 forks source link

Destroying fire does not work #612

Closed SpaceManiac closed 9 years ago

SpaceManiac commented 9 years ago

To remove fire, you start digging a block adjacent to it. Right now this instead destroys the dug block, and visually destroys the fire clientside without actually removing it.

DiggingHandler should be updated to detect the case where the dug block neighbors fire on the dug face and handle it by removing the fire and cancelling the dig.

Any fix should be tested in both survival and creative mode.

m3rcuriel commented 9 years ago

Should this still throw a BlockDamageEvent and/or BlockBreakEvent?

SpaceManiac commented 9 years ago

Tested on CB 1.7.10: no break event. Damage against the underlying block, but only in survival mode.

m3rcuriel commented 9 years ago

Alright, makes sense. Thanks.