Animal feeding improvements

[Pr0methean]

• Implements use of food for taming, horse healing, growth, or to set Love Mode.
• Animals won't consume food when it has none of these effects.
• GlowAbstractHorse.canBreed() can no longer return true if untamed.
• Implements the duration limit and the particle effect for Love Mode.

[aramperes]

What kind of live testing is required for this? Could you describe some testing steps?

[Pr0methean]

Test that:

• Animals descending from GlowAbstractHorse eventually become tamed when fed repeatedly
• Baby animals grow when fed
• Injured animals heal when fed
• Adult animals, except untamed GlowAbstractHorse, enter Love Mode when fed (currently doesn't affect behavior, but should create heart particles)
• More than one of those things can happen with the same piece of food
• Food isn't consumed if none of those things can happen
• Love Mode eventually expires

[FlorentClarret]

I tried your test and actually noticed some stuff:

• Heart particles are indeed created when an animal is fed, but the particles appear on their feet instead of above them, which looks a bit strange.
• Food is still consumed even if nothing else happens. I think it's because the canBreed method return always true if the animal is adult. I tested on cows and pigs.

The other things seem to work, I will also try to take a look soon to improve animal feeding

[Pr0methean]

@FlorentClarret For your test where food was falsely consumed, would the cow and pig have been expected to enter Love Mode? If not, why not?

[FlorentClarret]

I just gave wheat to a cow, which was not in love mode and the cow entered in love mode as expected, but after that the wheat is still consumed if I keep giving it wheat. I tried on vanilla an it's not the case, the wheat is not consumed if the cow is already in love mode.

[Pr0methean]

Both issues should be fixed now.